From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "Michał Mirosław" <mirqus@gmail.com>,
"Ben Greear" <greearb@candelatech.com>,
netdev@vger.kernel.org
Subject: Re: [RFC v2 2/2] e100: Support RXFCS feature flag.
Date: Tue, 12 Jul 2011 17:23:36 +0100 [thread overview]
Message-ID: <1310487816.2732.13.camel@bwh-desktop> (raw)
In-Reply-To: <20110712090000.29c17c20@nehalam.ftrdhcpuser.net>
On Tue, 2011-07-12 at 09:00 -0700, Stephen Hemminger wrote:
> On Tue, 12 Jul 2011 17:49:49 +0200
> Michał Mirosław <mirqus@gmail.com> wrote:
>
> > wanted_features only reflects what is requested by user, this
> > combination might be invalid. When conditions change this value
> > combined with other bits in features are passed through
> > ndo_fix_features callback and netdev_fix_features() to bring it to
> > valid state, and then (if resulting set is different than current
> > features) ndo_set_features() is called to reconfigure device for that
> > new state change to it.
>
> Since this semantic is more complicated than most other parts
> of network device interface API; could you please put a detailed
> documentation into Documentation/networking/netdevices.txt
>
> The whole netdevices.txt document could use some extending and
> rewriting as well.
Given that it has missed the last 3 years of API changes (and many
before that) I think it would be better to convert it into kernel-doc
comments in netdevice.h. That would make it more obvious to driver
authors trying to understand the API, and to those changing the driver
API.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-07-12 16:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 19:06 [RFC v2 0/2] Enable RX-FCS in e100 greearb
2011-06-24 19:06 ` [RFC v2 1/2] net: Support RXFCS feature flag greearb
2011-06-24 19:06 ` [RFC v2 2/2] e100: " greearb
2011-06-29 11:37 ` Michał Mirosław
2011-06-29 14:22 ` Ben Greear
2011-06-29 14:33 ` Michał Mirosław
2011-06-29 14:35 ` Ben Greear
2011-06-29 15:06 ` Michał Mirosław
2011-06-29 15:20 ` Ben Greear
2011-07-12 15:49 ` Michał Mirosław
2011-07-12 16:00 ` Stephen Hemminger
2011-07-12 16:23 ` Ben Hutchings [this message]
2011-07-12 19:01 ` [PATCH] net: Add documentation for netdev features handling Michał Mirosław
2011-07-12 19:19 ` Randy Dunlap
2011-07-12 19:41 ` [PATCH v2] " Michał Mirosław
2011-07-13 5:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310487816.2732.13.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=greearb@candelatech.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).