From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, netdev@vger.kernel.org
Subject: Re: [PATCH 07/10] net: remove NETIF_F_NO_CSUM feature
Date: Thu, 14 Jul 2011 01:59:47 +0100 [thread overview]
Message-ID: <1310605187.2756.14.camel@bwh-desktop> (raw)
In-Reply-To: <20110713174849.41dd634d@nehalam.ftrdhcpuser.net>
On Wed, 2011-07-13 at 17:48 -0700, Stephen Hemminger wrote:
> On Thu, 14 Jul 2011 01:23:29 +0100
> Ben Hutchings <bhutchings@solarflare.com> wrote:
>
> > On Thu, 2011-07-14 at 02:10 +0200, Michał Mirosław wrote:
> > > There are no explicit users, so this is now equivalent to NETIF_F_HW_CSUM.
> > [...]
> >
> > I think this is still a useful distinction, even the networking core
> > currently doesn't care about the difference.
> >
> > Ben.
>
> It also is a kernel API change since this part is exposed
> through ethtool calls.
Users of ETHTOOL_{G,S}FEATURES are supposed to use the corresponding
string set to map names to bits (and vice versa). It is OK to renumber
features, and to remove them if they are no longer implemented.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-07-14 0:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 0:10 [PATCH 00/10] net: random cleanups Michał Mirosław
2011-07-14 0:10 ` [PATCH 07/10] net: remove NETIF_F_NO_CSUM feature Michał Mirosław
2011-07-14 0:23 ` Ben Hutchings
2011-07-14 0:48 ` Stephen Hemminger
2011-07-14 0:59 ` Ben Hutchings [this message]
[not found] ` <CA+mtBx9GXf_+DGB4EabS74Hf+16KKJ78Ty_zK6Y3tC+X634jtA@mail.gmail.com>
2011-07-14 20:56 ` Michał Mirosław
2011-07-14 21:31 ` David Miller
2011-07-14 22:44 ` Michał Mirosław
2011-07-15 0:05 ` David Miller
2011-07-15 0:28 ` Michał Mirosław
2011-07-14 21:00 ` Michał Mirosław
2011-07-14 0:10 ` [PATCH 05/10] net: Disable NOCACHE_COPY by default Michał Mirosław
2011-07-14 0:44 ` Tom Herbert
2011-07-14 0:10 ` [PATCH 06/10] net: remove NETIF_F_ALL_TX_OFFLOADS Michał Mirosław
2011-07-14 21:43 ` David Miller
2011-07-14 21:54 ` Michał Mirosław
2011-07-14 21:58 ` David Miller
2011-07-14 22:34 ` [PATCH 1/1 net] net: fix bonding advertising offloads it can't support Michał Mirosław
2011-07-14 22:37 ` David Miller
2011-07-14 0:10 ` [PATCH 03/10] net: vlan: remove reduntant check in ndo_fix_features callback Michał Mirosław
2011-07-14 21:39 ` David Miller
2011-07-14 0:10 ` [PATCH 02/10] net: m68k/nfeth: Remove wrong usage of dev->flags Michał Mirosław
2011-07-14 21:38 ` David Miller
2011-07-14 0:10 ` [PATCH 04/10] net: cleanup vlan_features setting in register_netdev Michał Mirosław
2011-07-14 21:41 ` David Miller
2011-07-14 0:10 ` [PATCH 01/10] net: sctp: fix checksum marking for outgoing packets Michał Mirosław
2011-07-14 21:37 ` David Miller
2011-07-14 0:10 ` [PATCH 10/10] net: remove SK_ROUTE_CAPS from meta ematch Michał Mirosław
2011-07-14 0:52 ` Stephen Hemminger
2011-07-14 0:59 ` jamal
2011-07-14 20:50 ` Michał Mirosław
2011-07-14 20:52 ` David Miller
2011-07-14 21:46 ` David Miller
2011-07-14 0:10 ` [PATCH 08/10] net: unexport netdev_fix_features() Michał Mirosław
2011-07-14 21:44 ` David Miller
2011-07-14 0:10 ` [PATCH 09/10] net: remove /sys/class/net/*/features Michał Mirosław
2011-07-14 0:50 ` Stephen Hemminger
2011-07-14 1:03 ` Ben Hutchings
2011-07-14 1:16 ` Stephen Hemminger
2011-07-14 20:46 ` Michał Mirosław
2011-07-14 21:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310605187.2756.14.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox