From: "Sebastian Pöhn" <sebastian.belden@googlemail.com>
To: sandeep.kumar@freescale.com, sandeep.kumar@freescale.com,
netdev@vger.kernel.org, jpirko@redhat.com
Cc: "Sebastian Pöhn" <sebastian.poehn@belden.com>
Subject: RE: gianfar vlan
Date: Fri, 15 Jul 2011 09:59:03 +0200 [thread overview]
Message-ID: <1310716743.1789.9.camel@DENEC1DT0191> (raw)
Hi Jirka!
The rx queue filer table also needs the RCTRL_PRSDEP_INIT to be set. So I would suggest to add FILREN to RCTRL_REQ_PARSER.
Further I guess the parser should only be enabled if it is necessary (because of VLAN, IP, TCP or FILREN acceleration modes).
What about putting the
if (tempval & RCTRL_REQ_PARSER)
tempval |= RCTRL_PRSDEP_INIT;
else
tempval &= ~RCTRL_PRSDEP_INIT;
in a dedicated routine and call it every time one of the four features is altered?
Greetings
Sebastian
> Hi Sandeep.
>
> I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
> enabling/disabling to gfar_set_features() -> startup_gfar() ->
> gfar_init_mac(). I'm not sure how to handle following lines in
> gfar_vlan_rx_register():
>
> /* If parse is no longer required, then disable parser */
> if (tempval & RCTRL_REQ_PARSER)
> tempval |= RCTRL_PRSDEP_INIT;
> else
> tempval &= ~RCTRL_PRSDEP_INIT;
>
> Should this be done only on disabling vlan accel (both rx an tx)?
> Or can I just do that always in startup_gfar() ?
>
> Thanks.
>
> Jirka
next reply other threads:[~2011-07-15 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 7:59 Sebastian Pöhn [this message]
2011-07-15 9:16 ` gianfar vlan Jiri Pirko
-- strict thread matches above, loose matches on Subject: below --
2011-07-14 13:14 Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310716743.1789.9.camel@DENEC1DT0191 \
--to=sebastian.belden@googlemail.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sandeep.kumar@freescale.com \
--cc=sebastian.poehn@belden.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox