* gianfar vlan
@ 2011-07-14 13:14 Jiri Pirko
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2011-07-14 13:14 UTC (permalink / raw)
To: sandeep.kumar; +Cc: netdev, sebastian.poehn, davem, B06378
Hi Sandeep.
I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
enabling/disabling to gfar_set_features() -> startup_gfar() ->
gfar_init_mac(). I'm not sure how to handle following lines in
gfar_vlan_rx_register():
/* If parse is no longer required, then disable parser */
if (tempval & RCTRL_REQ_PARSER)
tempval |= RCTRL_PRSDEP_INIT;
else
tempval &= ~RCTRL_PRSDEP_INIT;
Should this be done only on disabling vlan accel (both rx an tx)?
Or can I just do that always in startup_gfar() ?
Thanks.
Jirka
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: gianfar vlan
@ 2011-07-15 7:59 Sebastian Pöhn
2011-07-15 9:16 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Pöhn @ 2011-07-15 7:59 UTC (permalink / raw)
To: sandeep.kumar, sandeep.kumar, netdev, jpirko; +Cc: Sebastian Pöhn
Hi Jirka!
The rx queue filer table also needs the RCTRL_PRSDEP_INIT to be set. So I would suggest to add FILREN to RCTRL_REQ_PARSER.
Further I guess the parser should only be enabled if it is necessary (because of VLAN, IP, TCP or FILREN acceleration modes).
What about putting the
if (tempval & RCTRL_REQ_PARSER)
tempval |= RCTRL_PRSDEP_INIT;
else
tempval &= ~RCTRL_PRSDEP_INIT;
in a dedicated routine and call it every time one of the four features is altered?
Greetings
Sebastian
> Hi Sandeep.
>
> I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
> enabling/disabling to gfar_set_features() -> startup_gfar() ->
> gfar_init_mac(). I'm not sure how to handle following lines in
> gfar_vlan_rx_register():
>
> /* If parse is no longer required, then disable parser */
> if (tempval & RCTRL_REQ_PARSER)
> tempval |= RCTRL_PRSDEP_INIT;
> else
> tempval &= ~RCTRL_PRSDEP_INIT;
>
> Should this be done only on disabling vlan accel (both rx an tx)?
> Or can I just do that always in startup_gfar() ?
>
> Thanks.
>
> Jirka
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gianfar vlan
2011-07-15 7:59 gianfar vlan Sebastian Pöhn
@ 2011-07-15 9:16 ` Jiri Pirko
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2011-07-15 9:16 UTC (permalink / raw)
To: Sebastian Pöhn; +Cc: sandeep.kumar, netdev, Sebastian Pöhn
Fri, Jul 15, 2011 at 09:59:03AM CEST, sebastian.belden@googlemail.com wrote:
>Hi Jirka!
>
>The rx queue filer table also needs the RCTRL_PRSDEP_INIT to be set. So I would suggest to add FILREN to RCTRL_REQ_PARSER.
>
>Further I guess the parser should only be enabled if it is necessary (because of VLAN, IP, TCP or FILREN acceleration modes).
>
>What about putting the
>
>if (tempval & RCTRL_REQ_PARSER)
> tempval |= RCTRL_PRSDEP_INIT;
>else
> tempval &= ~RCTRL_PRSDEP_INIT;
>
>in a dedicated routine and call it every time one of the four features is altered?
Ok why not. Would you please cook up the patch and post it? Thanks.
Jirka
>
>Greetings
>Sebastian
>
>> Hi Sandeep.
>>
>> I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
>> enabling/disabling to gfar_set_features() -> startup_gfar() ->
>> gfar_init_mac(). I'm not sure how to handle following lines in
>> gfar_vlan_rx_register():
>>
>> /* If parse is no longer required, then disable parser */
>> if (tempval & RCTRL_REQ_PARSER)
>> tempval |= RCTRL_PRSDEP_INIT;
>> else
>> tempval &= ~RCTRL_PRSDEP_INIT;
>>
>> Should this be done only on disabling vlan accel (both rx an tx)?
>> Or can I just do that always in startup_gfar() ?
>>
>> Thanks.
>>
>> Jirka
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-15 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-15 7:59 gianfar vlan Sebastian Pöhn
2011-07-15 9:16 ` Jiri Pirko
-- strict thread matches above, loose matches on Subject: below --
2011-07-14 13:14 Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).