Netdev List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Chetan Loke <loke.chetan@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 af-packet 2/2] Enhance af-packet to provide (near zero)lossless packet capture functionality.
Date: Sun, 17 Jul 2011 20:46:30 -0700	[thread overview]
Message-ID: <1310960790.2286.39.camel@Joe-Laptop> (raw)
In-Reply-To: <1310959610-1688-3-git-send-email-loke.chetan@gmail.com>

On Sun, 2011-07-17 at 23:26 -0400, Chetan Loke wrote:
> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
[]
> +#define V3_ALIGNMENT	(8)
> +#define ALIGN_V3(x)	(((x)+V3_ALIGNMENT-1)&~(V3_ALIGNMENT-1))

Maybe just use the kernel.h macro ALIGN()?

> +#define BLK_HDR_LEN	(ALIGN_V3(sizeof(struct block_desc)))

So this becomes:
#define BLK_HDR_LEN	ALIGN(sizeof(struct block_desc), V3_ALIGNMENT)



  reply	other threads:[~2011-07-18  3:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18  3:26 [PATCH net-next v3 af-packet 0/2] Enhance af-packet to provide (near zero)lossless packet capture functionality Chetan Loke
2011-07-18  3:26 ` [PATCH net-next v3 af-packet 1/2] " Chetan Loke
2011-07-18  6:38   ` Eric Dumazet
2011-07-18 12:49     ` chetan loke
2011-07-18 16:56       ` David Miller
2011-07-18  3:26 ` [PATCH net-next v3 af-packet 2/2] " Chetan Loke
2011-07-18  3:46   ` Joe Perches [this message]
2011-07-18 14:55     ` chetan loke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310960790.2286.39.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=loke.chetan@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox