Re: [PATCH 0/2] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods (v3)

Ben Hutchings
2011-08-22T17:33:37Z

On Mon, 2011-08-22 at 17:17 +0100, Ben Hutchings wrote:
[...]
> b. The flag means 'safe to send shared skbs in the way ptkgen does', and
> the restrictions this places on the user and driver should be specified.

We could specify something like:

The ndo_start_xmit operation for this interface either does not
modify the given skb or modifies it idempotently. A single skb
may be transmitted repeatedly on a single queue of this
interface, but not on multiple queues or on multiple interfaces.

Does that look correct?

Ben.

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.