Re: [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods

Eric Dumazet
2011-07-20T04:24:22Z

Le mardi 19 juillet 2011 à 22:07 -0400, Neil Horman a écrit :
> >
> I think this is a good idea. It lets pktgen dynamically make the clone/share
> decision dynamically and only impacts performance for those systems.
>

Just let pktgen refuse to use clone_skb command for these devices.

At that point, an userland application is going to be faster and more
flexible than pktgen.

So when I said "remove pktgen" from distro it was not a joke.
Maybe its time to admit pktgen has to be removed from kernel sources.

$ wc net/core/pktgen.c
3788 10881 92771 net/core/pktgen.c

Hmmm, 3788 lines, patched 180 times for a thing that only sends UDP
frames...