RE: [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods

Loke, Chetan
2011-07-20T15:17:13Z

> So when I said "remove pktgen" from distro it was not a joke.
> Maybe its time to admit pktgen has to be removed from kernel sources.
>

Please, let's not remove pktgen from kernel sources. We can add a CONFIG_PKTGEN as someone mentioned in the email thread.

> $ wc net/core/pktgen.c
> 3788 10881 92771 net/core/pktgen.c
>
> Hmmm, 3788 lines, patched 180 times for a thing that only sends UDP
> frames...

It really doesn't matter what traffic it sends. As long as I can get some high speed throughput I am good.
There are quite a few use-cases where one doesn't really need to know the traffic profile.