Re: [PATCH 2/2] net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared

Krzysztof Halasa
2011-07-26T18:34:48Z

Neil Horman <nhorman@tuxdriver.com> writes:

> After the last patch, We are left in a state in which only drivers calling
> ether_setup have IFF_TX_SKB_SHARING set (we assume that drivers touching real
> hardware call ether_setup for their net_devices and don't hold any state in
> their skbs. There are a handful of drivers that violate this assumption of
> course, and need to be fixed up. This patch identifies those drivers, and marks
> them as not being able to support the safe transmission of skbs by clearning the
> IFF_TX_SKB_SHARING flag in priv_flags

> --- a/drivers/net/wan/hdlc_fr.c
> +++ b/drivers/net/wan/hdlc_fr.c
> @@ -1074,9 +1074,10 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
>
> used = pvc_is_used(pvc);
>
> - if (type == ARPHRD_ETHER)
> + if (type == ARPHRD_ETHER) {
> dev = alloc_netdev(0, "pvceth%d", ether_setup);
> - else
> + dev->priv_flags &= ~IFF_TX_SKB_SHARING;
> + } else
> dev = alloc_netdev(0, "pvc%d", pvc_setup);
>
> if (!dev) {

That's right, hdlc_fr has to add an additional header.

Acked-by: Krzysztof Hałasa <khc@pm.waw.pl>
--
Krzysztof Halasa