From: Eric Dumazet <eric.dumazet@gmail.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Fernando Gont <fernando@gont.com.ar>,
David Miller <davem@davemloft.net>,
security@kernel.org, Eugene Teo <eugeneteo@kernel.sg>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] ipv6: make fragment identifications less predictable
Date: Wed, 20 Jul 2011 08:50:48 +0200 [thread overview]
Message-ID: <1311144648.3113.114.camel@edumazet-laptop> (raw)
In-Reply-To: <1311109019.14555.11.camel@calx>
Le mardi 19 juillet 2011 à 15:56 -0500, Matt Mackall a écrit :
> On Tue, 2011-07-19 at 22:47 +0200, Eric Dumazet wrote:
> > IPv6 fragment identification generation is way beyond what we use for
> > IPv4 : It uses a single generator. Its not scalable and allows DOS
> > attacks.
> >
> > Now inetpeer is IPv6 aware, we can use it to provide a more secure and
> > scalable frag ident generator (per destination, instead of system wide)
>
> This code really needs to get moved out of random.c and into net/. Other
> than that, looks fine to me.
Sure. Can we agree to make this cleanup later ?
I added secure_ipv6_id() right after secure_ip_id() because it sounded
the right place ;)
next prev parent reply other threads:[~2011-07-20 6:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E24BE94.7010301@gont.com.ar>
[not found] ` <1311082696.2375.26.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
[not found] ` <1311089463.2375.42.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
2011-07-19 20:47 ` [PATCH net-next-2.6] ipv6: make fragment identifications less predictable Eric Dumazet
2011-07-19 20:56 ` Matt Mackall
2011-07-20 6:50 ` Eric Dumazet [this message]
2011-07-20 8:25 ` Eric Dumazet
2011-07-20 10:27 ` Eric Dumazet
2011-07-21 1:32 ` Fernando Gont
2011-07-21 22:17 ` David Miller
2011-07-21 22:46 ` Rick Jones
2011-07-21 23:13 ` David Miller
2011-07-21 23:37 ` Fernando Gont
2011-07-22 0:07 ` David Miller
2011-07-22 0:34 ` Rick Jones
2011-07-22 1:18 ` Fernando Gont
2011-07-22 4:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311144648.3113.114.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=eugeneteo@kernel.sg \
--cc=fernando@gont.com.ar \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox