Re: [PATCH net-next-2.6] bonding: reduce noise during init

[Joe Perches <joe@perches.com>]

On Tue, 2011-07-26 at 17:35 -0400, Andy Gospodarek wrote:
> Many are using sysfs to configure bonding rather than module options, so
> there is no need for bonding to throw this warning in normal cases.
> Keep the message around when debugging is enabled as it might be useful
> for someone desperate enough to enable debugging, but eliminate it
> otherwise.
[]
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
[]
> @@ -4745,7 +4745,10 @@ static int bond_check_params(struct bond_params *params)
>  		/* miimon and arp_interval not set, we need one so things
>  		 * work as expected, see bonding.txt for details
>  		 */
> -		pr_warning("Warning: either miimon or arp_interval and arp_ip_target module parameters must be specified, otherwise bonding will not detect link failures! see bonding.txt for details.\n");
> +		pr_debug("Warning: either miimon or arp_interval and"
> +			 " arp_ip_target module parameters must be specified,"
> +			 " otherwise bonding will not detect link failures!"
> +			 "  See bonding.txt for details.\n");

I'd prefer you don't separate the format string
into multiple pieces.