From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [patch net-next-2.6] dummy: allow report link status and change it via sysfs Date: Fri, 29 Jul 2011 18:03:09 +0200 Message-ID: <1311955389.3220.15.camel@deadeye> References: <1311953253-25059-1-git-send-email-jpirko@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, eric.dumazet@gmail.com To: Jiri Pirko Return-path: Received: from exchange.solarflare.com ([216.237.3.220]:52435 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174Ab1G2QDP (ORCPT ); Fri, 29 Jul 2011 12:03:15 -0400 In-Reply-To: <1311953253-25059-1-git-send-email-jpirko@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2011-07-29 at 17:27 +0200, Jiri Pirko wrote: > Signed-off-by: Jiri Pirko > --- > drivers/net/dummy.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 54 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c > index 39cf9b9..fc39c24 100644 > --- a/drivers/net/dummy.c > +++ b/drivers/net/dummy.c > @@ -37,9 +37,57 @@ > #include > #include > #include > +#include > > static int numdummies = 1; > > +static ssize_t dummy_show_link(struct device *d, > + struct device_attribute *attr, > + char *buf) > +{ > + struct net_device *dev = to_net_dev(d); > + > + return sprintf(buf, "%d\n", netif_carrier_ok(dev) ? 1 : 0); > +} [...] Net devices already have the 'carrier' attribute. You should make that attribute writable for dummy devices, rather than adding another one. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.