From: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>,
U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [RFC 4/5] [flexcan] Add support for FLEXCAN_DEBUG
Date: Sat, 6 Aug 2011 09:34:29 -0500 [thread overview]
Message-ID: <1312641270-6018-5-git-send-email-holt@sgi.com> (raw)
In-Reply-To: <1312641270-6018-1-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
Add a wrapper function for a register dump when a developer defines
FLEXCAN_DEBUG.
Signed-off-by: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
drivers/net/can/flexcan.c | 37 +++++++++++++++++++++++++++++++++++++
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index d4ac81b..c2fb829 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -215,6 +215,35 @@ static inline void flexcan_write(u32 val, void __iomem *addr)
}
#endif
+#if defined(FLEXCAN_DEBUG)
+void _flexcan_reg_dump(struct net_device *dev, const char *file, int line,
+ const char *func)
+{
+ const struct flexcan_priv *priv = netdev_priv(dev);
+ struct flexcan_regs __iomem *regs = priv->base;
+
+ netdev_info("flexcan_reg_dump:%s:%d:%s()\n", file, line, func);
+ netdev_info("\t mcr 0x%08x ctrl 0x%08x timer 0x%08x rxg 0x%08x",
+ flexcan_read(®s->mcr),
+ flexcan_read(®s->ctrl),
+ flexcan_read(®s->timer),
+ flexcan_read(®s->rxgmask));
+ netdev_info("\t rx14 0x%08x rx15 0x%08x ecr 0x%08x esr 0x%08x",
+ flexcan_read(®s->rx14mask),
+ flexcan_read(®s->rx15mask),
+ flexcan_read(®s->ecr),
+ flexcan_read(®s->esr));
+ netdev_info("\timsk2 0x%08x imsk1 0x%08x iflg2 0x%08x iflg1 0x%08x",
+ flexcan_read(®s->imask2),
+ flexcan_read(®s->imask1),
+ flexcan_read(®s->iflag2),
+ flexcan_read(®s->iflag1));
+}
+#define flexcan_reg_dump(_d) _flexcan_reg_dump(_d, __FILE__, __LINE__, __func__)
+#else
+#define flexcan_reg_dump(_d)
+#endif
+
/*
* Swtich transceiver on or off
*/
@@ -275,6 +304,8 @@ static int flexcan_start_xmit(struct sk_buff *skb, struct net_device *dev)
u32 can_id;
u32 ctrl = FLEXCAN_MB_CNT_CODE(0xc) | (cf->can_dlc << 16);
+ flexcan_reg_dump(dev);
+
if (can_dropped_invalid_skb(dev, skb))
return NETDEV_TX_OK;
@@ -307,6 +338,8 @@ static int flexcan_start_xmit(struct sk_buff *skb, struct net_device *dev)
/* tx_packets is incremented in flexcan_irq */
stats->tx_bytes += cf->can_dlc;
+ flexcan_reg_dump(dev);
+
return NETDEV_TX_OK;
}
@@ -575,6 +608,8 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id)
struct flexcan_regs __iomem *regs = priv->base;
u32 reg_iflag1, reg_esr;
+ flexcan_reg_dump(dev);
+
reg_iflag1 = flexcan_read(®s->iflag1);
reg_esr = flexcan_read(®s->esr);
flexcan_write(FLEXCAN_ESR_ERR_INT, ®s->esr); /* ACK err IRQ */
@@ -615,6 +650,8 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id)
netif_wake_queue(dev);
}
+ flexcan_reg_dump(dev);
+
return IRQ_HANDLED;
}
--
1.7.2.1
next prev parent reply other threads:[~2011-08-06 14:34 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 14:34 [RFC 0/4] [flexcan] Add support for powerpc (freescale p1010) -V6 Robin Holt
2011-08-06 14:34 ` [RFC 2/5] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-06 14:34 ` [RFC 3/5] [flexcan] Add of_match to platform_device definition Robin Holt
[not found] ` <1312641270-6018-1-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-06 14:34 ` [RFC 1/5] [flexcan] Replace mach/clock.h with linux/clkdev.h Robin Holt
2011-08-06 14:34 ` Robin Holt [this message]
2011-08-06 14:34 ` [RFC 5/5] [powerpc] Implement a p1010rdb clock source Robin Holt
[not found] ` <1312641270-6018-6-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-08 8:37 ` Wolfgang Grandegger
[not found] ` <4E3FA066.3020301-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 9:15 ` Robin Holt
2011-08-08 11:31 ` Robin Holt
2011-08-08 13:05 ` Marc Kleine-Budde
[not found] ` <20110808113136.GS4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 12:07 ` Marc Kleine-Budde
[not found] ` <4E3FD184.1070706-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-08 12:48 ` Robin Holt
[not found] ` <20110808124842.GT4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 13:00 ` Marc Kleine-Budde
[not found] ` <4E3FDDD6.1020802-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-08 13:16 ` Wolfgang Grandegger
2011-08-08 13:08 ` Wolfgang Grandegger
[not found] ` <4E3FDFC9.7080508-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 13:44 ` Marc Kleine-Budde
[not found] ` <4E3FE844.6090005-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-08 14:03 ` Robin Holt
[not found] ` <20110808140340.GV4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 14:19 ` Marc Kleine-Budde
[not found] ` <4E3FF068.6070905-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-08 14:29 ` Robin Holt
2011-08-08 14:19 ` Wolfgang Grandegger
2011-08-08 13:56 ` Robin Holt
[not found] ` <20110808135630.GU4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 14:16 ` Wolfgang Grandegger
[not found] ` <4E3FEFBB.9050103-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 14:21 ` Robin Holt
[not found] ` <20110808142153.GW4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 14:37 ` Wolfgang Grandegger
[not found] ` <4E3FF4B8.2010603-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 14:44 ` Robin Holt
[not found] ` <20110808144424.GY4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 14:59 ` Wolfgang Grandegger
[not found] ` <4E3FF9EA.6030601-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 15:09 ` Robin Holt
[not found] ` <20110808150925.GA4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 15:18 ` Wolfgang Grandegger
[not found] ` <4E3FFE61.4090109-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 15:22 ` Wolfgang Grandegger
[not found] ` <4E3FFF41.7030401-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 15:38 ` Robin Holt
[not found] ` <20110808153835.GC4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 15:50 ` Wolfgang Grandegger
2011-08-08 15:23 ` Marc Kleine-Budde
2011-08-08 15:25 ` Robin Holt
[not found] ` <20110808152549.GB4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 15:27 ` Wolfgang Grandegger
2011-08-08 15:14 ` Marc Kleine-Budde
[not found] ` <4E3FFD5B.7080000-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-08 15:33 ` Wolfgang Grandegger
[not found] ` <4E4001E1.3030508-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 15:55 ` Robin Holt
[not found] ` <20110808155540.GD4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 15:59 ` Robin Holt
2011-08-08 16:03 ` Wolfgang Grandegger
[not found] ` <4E4008BA.6030303-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 16:08 ` Robin Holt
[not found] ` <20110808160810.GF4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 18:37 ` Wolfgang Grandegger
[not found] ` <4E402CF1.1040300-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-08 19:14 ` Robin Holt
2011-08-08 20:27 ` Robin Holt
2011-08-08 18:53 ` Marc Kleine-Budde
2011-08-09 7:57 ` U Bhaskar-B22300
[not found] ` <9C64B7751C3BCA41B64A68E23005A7BE1B9D6C-TcFNo7jSaXPiTqIcKZ1S2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-09 8:13 ` Marc Kleine-Budde
2011-08-09 9:34 ` U Bhaskar-B22300
[not found] ` <9C64B7751C3BCA41B64A68E23005A7BE1BEFCE-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-09 10:41 ` Wolfgang Grandegger
2011-08-09 8:32 ` Wolfgang Grandegger
2011-08-09 9:27 ` U Bhaskar-B22300
2011-08-09 10:48 ` Wolfgang Grandegger
[not found] ` <4E41108F.1090104-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-09 12:41 ` U Bhaskar-B22300
[not found] ` <9C64B7751C3BCA41B64A68E23005A7BE1C3552-TcFNo7jSaXPiTqIcKZ1S2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-09 12:49 ` Robin Holt
[not found] ` <20110809124919.GS4926-sJ/iWh9BUns@public.gmane.org>
2011-08-09 13:03 ` Wolfgang Grandegger
2011-08-09 13:17 ` Robin Holt
[not found] ` <4E413036.5080207-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-09 13:35 ` Robin Holt
[not found] ` <20110809133531.GV4926-sJ/iWh9BUns@public.gmane.org>
2011-08-09 13:44 ` U Bhaskar-B22300
[not found] ` <9C64B7751C3BCA41B64A68E23005A7BE1C4746-TcFNo7jSaXPiTqIcKZ1S2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-09 13:50 ` Robin Holt
2011-08-09 14:03 ` Wolfgang Grandegger
2011-08-09 14:09 ` Robin Holt
[not found] ` <20110809140901.GX4926-sJ/iWh9BUns@public.gmane.org>
2011-08-09 14:14 ` Wolfgang Grandegger
2011-08-09 12:50 ` Marc Kleine-Budde
[not found] ` <4E412D26.9020608-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-09 12:54 ` U Bhaskar-B22300
2011-08-09 13:19 ` Wolfgang Grandegger
2011-08-08 14:48 ` Robin Holt
[not found] ` <20110808144808.GZ4926-sJ/iWh9BUns@public.gmane.org>
2011-08-08 15:16 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312641270-6018-5-git-send-email-holt@sgi.com \
--to=holt-sj/iwh9buns@public.gmane.org \
--cc=B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).