From: Tim Chen <tim.c.chen@linux.intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
"David S. Miller" <davem@davemloft.net>,
Al Viro <viro@zeniv.linux.org.uk>,
ak@linux.intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: [Patch] scm: Capture the full credentials of the scm sender
Date: Tue, 09 Aug 2011 09:48:32 -0700 [thread overview]
Message-ID: <1312908512.2576.97.camel@schen9-DESK> (raw)
In-Reply-To: <1312857834.2531.15.camel@edumazet-laptop>
On Tue, 2011-08-09 at 04:43 +0200, Eric Dumazet wrote:
> Good catch Tim.
>
> BTW your patch is a bit flawed : one wrapped line and "---" marker
> missing.
>
> Could you add in Changelog bug came from commit 257b5358b32f17
> (scm: Capture the full credentials of the scm sender) to ease stable
> teams work ?
> (linux-2.6.36 was the first kernel to include this commit)
>
>
>
Updated the log as requested. Thanks.
Tim
------------
This patch corrects an erroneous update of credential's gid with uid
introduced in commit 257b5358b32f17 since 2.6.36.
Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
---
diff --git a/net/core/scm.c b/net/core/scm.c
index 4c1ef02..811b53f 100644
--- a/net/core/scm.c
+++ b/net/core/scm.c
@@ -192,7 +192,7 @@ int __scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie *p)
goto error;
cred->uid = cred->euid = p->creds.uid;
- cred->gid = cred->egid = p->creds.uid;
+ cred->gid = cred->egid = p->creds.gid;
put_cred(p->cred);
p->cred = cred;
}
next prev parent reply other threads:[~2011-08-09 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 22:08 [Patch] Correct assignment of uid to gid in credentials Tim Chen
2011-08-09 2:43 ` Eric Dumazet
2011-08-09 16:48 ` Tim Chen [this message]
2011-08-09 18:06 ` [Patch] scm: Capture the full credentials of the scm sender Andi Kleen
2011-08-09 18:12 ` Eric Dumazet
2011-08-09 23:20 ` James Morris
2011-08-11 12:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312908512.2576.97.camel@schen9-DESK \
--to=tim.c.chen@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox