From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c Date: Tue, 09 Aug 2011 12:57:15 -0700 Message-ID: <1312919835.11924.26.camel@Joe-Laptop> References: <1312907945-1982-1-git-send-email-wangshaoyan.pt@taobao.com> <1312908784.2371.53.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1312912326.11924.12.camel@Joe-Laptop> <1312912774.2547.1.camel@edumazet-laptop> <1312913545.11924.16.camel@Joe-Laptop> <1312914257.2547.10.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, stufever@gmail.com, netdev@vger.kernel.org, davem@davemloft.net, Wang Shaoyan To: Eric Dumazet Return-path: In-Reply-To: <1312914257.2547.10.camel@edumazet-laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2011-08-09 at 20:24 +0200, Eric Dumazet wrote: > Le mardi 09 ao=C3=BBt 2011 =C3=A0 11:12 -0700, Joe Perches a =C3=A9cr= it : > > On Tue, 2011-08-09 at 19:59 +0200, Eric Dumazet wrote: > > > Le mardi 09 ao=C3=BBt 2011 =C3=A0 10:52 -0700, Joe Perches a =C3=A9= crit : > > > > On Tue, 2011-08-09 at 18:53 +0200, Eric Dumazet wrote: > > > > > Le mercredi 10 ao=C3=BBt 2011 =C3=A0 00:39 +0800, stufever@gm= ail.com a =C3=A9crit : > > > > [] > > > > > > + if (!local_rqfpr || !local_rqfcr) { > > > > > > + pr_err("Out of memory\n"); > > > > > Please remove this pr_err(), kmalloc() will complain already= =2E I think this is fine and should be kept until some general agreement is made that OOM messages should be removed generically. If these are really superfluous, which I doubt a little because these are emitted at different KERN_, (the generic one emits at KERN_WARNING), there are _thousands_ of these OOM errors in drivers/ alone that could be removed. $ grep -rP --include=3D*.[ch] \ "(printk|\b[a-z]+_\w+)\s*\(.*\".*(alloc|mem)" drivers | \ wc -l 5147 call it 50% false positive, it's still a lot. I think one more won't hurt for awhile.