Re: [linux-firmware v2 1/2] rtl_nic: update firmware for RTL8111E-VL

Ben Hutchings
2011-08-10T12:54:28Z

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

On Wed, 2011-08-10 at 20:22 +0800, Hayes Wang wrote:
> Updated firmware with stability fixes.
> Version: rtl8168e-3_0.0.1.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
> WHENCE | 2 +-
> rtl_nic/rtl8168e-3.fw | Bin 2804 -> 3264 bytes
> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/WHENCE b/WHENCE
> index 4b88f1f..a463417 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -1626,7 +1626,7 @@ File: rtl_nic/rtl8168d-2.fw
> File: rtl_nic/rtl8105e-1.fw
> File: rtl_nic/rtl8168e-1.fw
> File: rtl_nic/rtl8168e-2.fw
> -File: rtl_nic/rtl8168e-3.fw
> +File: rtl_nic/rtl8168e-3.fw (Version: rtl8168e-3_0.0.1)
[...]

Please don't write the version in yet another way. It should be:

File: rtl_nic/rtl8168e-3.fw
Version: 0.0.1

Or, if you insist on duplicating the name in the version:

File: rtl_nic/rtl8168e-3.fw
Version: rtl8168e-3_0.0.1

Ben.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]