RE: [linux-firmware v2 1/2] rtl_nic: update firmware forRTL8111E-VL

hayeswang
2011-08-11T03:41:34Z

> -----Original Message-----
> From: Ben Hutchings [mailto:ben@decadent.org.uk]
> > +File: rtl_nic/rtl8168e-3.fw (Version: rtl8168e-3_0.0.1)
> [...]
>
> Please don't write the version in yet another way. It should be:
>

I just think if someone replaces the firmware with another one, I could check
the firmware through the information without checking the ram data.
For example, someone renames the rtl8168f-1.fw to rtl8168e-3.fw and replaces the
original rtl8168e-3.fw. Through ethtool to show the version of the firmware, I
could know the firmware is invalid. If the version only contain the value 0.0.1,
I must compare the binary file to find out the result.

Do you think it is unnecessary to add this information? I could remove the
relative part if you think so.

> File: rtl_nic/rtl8168e-3.fw
> Version: 0.0.1
>
> Or, if you insist on duplicating the name in the version:
>
> File: rtl_nic/rtl8168e-3.fw
> Version: rtl8168e-3_0.0.1
>

Best Regards,
Hayes