* [PATCH 06/11] drivers/net/bna: do not use EXTRA_CFLAGS [not found] <1313384834-24433-1-git-send-email-lacombar@gmail.com> @ 2011-08-15 5:07 ` Arnaud Lacombe 2011-08-15 5:16 ` Arnaud Lacombe 0 siblings, 1 reply; 2+ messages in thread From: Arnaud Lacombe @ 2011-08-15 5:07 UTC (permalink / raw) To: linux-kernel; +Cc: Arnaud Lacombe, Sam Ravnborg, Rasesh Mody, netdev Usage of these flags has been deprecated for nearly 4 years by: commit f77bf01425b11947eeb3b5b54685212c302741b8 Author: Sam Ravnborg <sam@neptun.(none)> Date: Mon Oct 15 22:25:06 2007 +0200 kbuild: introduce ccflags-y, asflags-y and ldflags-y Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command line use. By default, gmake(1) do not override command line setting, so this is likely to result in build failure or unexpected behavior. Replace their usage by Kbuild's `{as,cc,ld}flags-y'. Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Rasesh Mody <rmody@brocade.com> Cc: netdev@vger.kernel.org --- drivers/net/bna/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/bna/Makefile b/drivers/net/bna/Makefile index a5d604d..babc25f 100644 --- a/drivers/net/bna/Makefile +++ b/drivers/net/bna/Makefile @@ -8,4 +8,4 @@ obj-$(CONFIG_BNA) += bna.o bna-objs := bnad.o bnad_ethtool.o bna_ctrl.o bna_txrx.o bna-objs += bfa_ioc.o bfa_ioc_ct.o bfa_cee.o cna_fwimg.o -EXTRA_CFLAGS := -Idrivers/net/bna +ccflags-y := -Idrivers/net/bna -- 1.7.6.153.g78432 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 06/11] drivers/net/bna: do not use EXTRA_CFLAGS 2011-08-15 5:07 ` [PATCH 06/11] drivers/net/bna: do not use EXTRA_CFLAGS Arnaud Lacombe @ 2011-08-15 5:16 ` Arnaud Lacombe 0 siblings, 0 replies; 2+ messages in thread From: Arnaud Lacombe @ 2011-08-15 5:16 UTC (permalink / raw) To: linux-kernel; +Cc: Arnaud Lacombe, Sam Ravnborg, Rasesh Mody, netdev Hi, On Mon, Aug 15, 2011 at 1:07 AM, Arnaud Lacombe <lacombar@gmail.com> wrote: > Usage of these flags has been deprecated for nearly 4 years by: > > commit f77bf01425b11947eeb3b5b54685212c302741b8 > Author: Sam Ravnborg <sam@neptun.(none)> > Date: Mon Oct 15 22:25:06 2007 +0200 > > kbuild: introduce ccflags-y, asflags-y and ldflags-y > > Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command > line use. By default, gmake(1) do not override command line setting, so this is > likely to result in build failure or unexpected behavior. > > Replace their usage by Kbuild's `{as,cc,ld}flags-y'. > > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Rasesh Mody <rmody@brocade.com> > Cc: netdev@vger.kernel.org Signed-off-by: Arnaud Lacombe <lacombar@gmail.com> - Arnaud > --- > drivers/net/bna/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bna/Makefile b/drivers/net/bna/Makefile > index a5d604d..babc25f 100644 > --- a/drivers/net/bna/Makefile > +++ b/drivers/net/bna/Makefile > @@ -8,4 +8,4 @@ obj-$(CONFIG_BNA) += bna.o > bna-objs := bnad.o bnad_ethtool.o bna_ctrl.o bna_txrx.o > bna-objs += bfa_ioc.o bfa_ioc_ct.o bfa_cee.o cna_fwimg.o > > -EXTRA_CFLAGS := -Idrivers/net/bna > +ccflags-y := -Idrivers/net/bna > -- > 1.7.6.153.g78432 > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-15 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1313384834-24433-1-git-send-email-lacombar@gmail.com>
2011-08-15 5:07 ` [PATCH 06/11] drivers/net/bna: do not use EXTRA_CFLAGS Arnaud Lacombe
2011-08-15 5:16 ` Arnaud Lacombe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox