Netdev List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] fix IBM EMAC driver after rename.
Date: Thu, 18 Aug 2011 21:09:58 -0700	[thread overview]
Message-ID: <1313726998.11178.10.camel@Joe-Laptop> (raw)
In-Reply-To: <20110819035730.GI19739@ozlabs.org>

On Fri, 2011-08-19 at 13:57 +1000, Tony Breeds wrote:
> On Thu, Aug 18, 2011 at 08:44:00PM -0700, David Miller wrote:
> > Don't do this :-(  When you reply to me as your new version of the patch
> > it craps up the commit message.
> > Always make a fresh, new, patch posting with a clean full commit message
> > without any non-essential material included.
> > I'm not applying this, because I'm pretty sick and tired of having to
> > edit up people's patch postings when they do stuff like this.
> Sorry I thought git am coped with this.

It can if you move the quoted stuff below the
---
separator, though I don't know what patchworks
does with threaded [PATCH V2] content.  I do
think it's useful when the corrected patch
is appropriately threaded.

The corrected patch email could look like:

Subject: [PATCH V2] module: description

typical multi-line patch description...

Signed-off-by: etc

---

> On some date, somebody wrote:
> quoted stuff

Description of delta between patch 1 and patch 2.

actual patch...



  reply	other threads:[~2011-08-19  4:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-18  6:13 [PATCH] fix IBM EMAC driver after rename Tony Breeds
2011-08-18  6:49 ` David Miller
2011-08-19  1:25   ` Tony Breeds
2011-08-19  3:44     ` David Miller
2011-08-19  3:57       ` Tony Breeds
2011-08-19  4:09         ` Joe Perches [this message]
2011-08-18  6:50 ` Oliver Hartkopp
2011-08-19  1:21   ` Tony Breeds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313726998.11178.10.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=tony@bakeyournoodle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox