* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features [not found] <cover.1308758435.git.mirq-linux@rere.qmqm.pl> @ 2011-06-22 23:11 ` Ben Greear 2011-06-27 14:21 ` Michał Mirosław 2011-08-25 19:04 ` Ben Greear 1 sibling, 1 reply; 8+ messages in thread From: Ben Greear @ 2011-06-22 23:11 UTC (permalink / raw) To: Michał Mirosław; +Cc: netdev, David S. Miller, Ben Hutchings On 06/22/2011 09:04 AM, Michał Mirosław wrote: > v3 of a feature handling cleanup and extension series. For testing, you > might want user-space ethtool patched with: > > http://patchwork.ozlabs.org/patch/96374/ There is a typo in one of those patches: CC fs/quota/netlink.o /home/greearb/git/net-next-2.6/net/core/dev.c: In function ‘__netdev_update_features’: /home/greearb/git/net-next-2.6/net/core/dev.c:5288: warning: too many arguments for format CC net/core/ethtool.o netdev_dbg(dev, "Features changed: %pNF -> pNF\n", &dev->features, &features); Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features 2011-06-22 23:11 ` [RFT PATCH v3 00/12] Cleanup and extension of netdev features Ben Greear @ 2011-06-27 14:21 ` Michał Mirosław 0 siblings, 0 replies; 8+ messages in thread From: Michał Mirosław @ 2011-06-27 14:21 UTC (permalink / raw) To: Ben Greear; +Cc: netdev, David S. Miller, Ben Hutchings On Wed, Jun 22, 2011 at 04:11:28PM -0700, Ben Greear wrote: > On 06/22/2011 09:04 AM, Michał Mirosław wrote: > >v3 of a feature handling cleanup and extension series. For testing, you > >might want user-space ethtool patched with: > > > >http://patchwork.ozlabs.org/patch/96374/ > There is a typo in one of those patches: > CC fs/quota/netlink.o > /home/greearb/git/net-next-2.6/net/core/dev.c: In function ‘__netdev_update_features’: > /home/greearb/git/net-next-2.6/net/core/dev.c:5288: warning: too many arguments for format > CC net/core/ethtool.o > netdev_dbg(dev, "Features changed: %pNF -> pNF\n", > &dev->features, &features); Noted for next version. Best Regards, Michał Mirosław ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features [not found] <cover.1308758435.git.mirq-linux@rere.qmqm.pl> 2011-06-22 23:11 ` [RFT PATCH v3 00/12] Cleanup and extension of netdev features Ben Greear @ 2011-08-25 19:04 ` Ben Greear 2011-08-26 16:41 ` David Miller 2011-08-26 18:41 ` Michał Mirosław 1 sibling, 2 replies; 8+ messages in thread From: Ben Greear @ 2011-08-25 19:04 UTC (permalink / raw) To: Michał Mirosław; +Cc: netdev, David S. Miller, Ben Hutchings On 06/22/2011 09:04 AM, Michał Mirosław wrote: > v3 of a feature handling cleanup and extension series. For testing, you > might want user-space ethtool patched with: > > http://patchwork.ozlabs.org/patch/96374/ It looks like this is not in net-next yet...any hope of this going in soon? Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features 2011-08-25 19:04 ` Ben Greear @ 2011-08-26 16:41 ` David Miller 2011-08-26 16:43 ` Ben Greear 2011-08-26 18:41 ` Michał Mirosław 1 sibling, 1 reply; 8+ messages in thread From: David Miller @ 2011-08-26 16:41 UTC (permalink / raw) To: greearb; +Cc: mirq-linux, netdev, bhutchings From: Ben Greear <greearb@candelatech.com> Date: Thu, 25 Aug 2011 12:04:40 -0700 > On 06/22/2011 09:04 AM, Michał Mirosław wrote: >> v3 of a feature handling cleanup and extension series. For testing, >> you >> might want user-space ethtool patched with: >> >> http://patchwork.ozlabs.org/patch/96374/ > > It looks like this is not in net-next yet...any hope of this > going in soon? Why would it go into net-next? It's not a kernel patch, it's a patch for the ethool userland utility. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features 2011-08-26 16:41 ` David Miller @ 2011-08-26 16:43 ` Ben Greear 2011-08-26 16:47 ` David Miller 0 siblings, 1 reply; 8+ messages in thread From: Ben Greear @ 2011-08-26 16:43 UTC (permalink / raw) To: David Miller; +Cc: mirq-linux, netdev, bhutchings On 08/26/2011 09:41 AM, David Miller wrote: > From: Ben Greear<greearb@candelatech.com> > Date: Thu, 25 Aug 2011 12:04:40 -0700 > >> On 06/22/2011 09:04 AM, Michał Mirosław wrote: >>> v3 of a feature handling cleanup and extension series. For testing, >>> you >>> might want user-space ethtool patched with: >>> >>> http://patchwork.ozlabs.org/patch/96374/ >> >> It looks like this is not in net-next yet...any hope of this >> going in soon? > > Why would it go into net-next? It's not a kernel patch, it's a patch > for the ethool userland utility. I meant the kernel bits in that patch series, not the link. Sorry for not snipping enough. Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features 2011-08-26 16:43 ` Ben Greear @ 2011-08-26 16:47 ` David Miller 0 siblings, 0 replies; 8+ messages in thread From: David Miller @ 2011-08-26 16:47 UTC (permalink / raw) To: greearb; +Cc: mirq-linux, netdev, bhutchings From: Ben Greear <greearb@candelatech.com> Date: Fri, 26 Aug 2011 09:43:19 -0700 > On 08/26/2011 09:41 AM, David Miller wrote: >> From: Ben Greear<greearb@candelatech.com> >> Date: Thu, 25 Aug 2011 12:04:40 -0700 >> >>> On 06/22/2011 09:04 AM, Michał Mirosław wrote: >>>> v3 of a feature handling cleanup and extension series. For testing, >>>> you >>>> might want user-space ethtool patched with: >>>> >>>> http://patchwork.ozlabs.org/patch/96374/ >>> >>> It looks like this is not in net-next yet...any hope of this >>> going in soon? >> >> Why would it go into net-next? It's not a kernel patch, it's a patch >> for the ethool userland utility. > > I meant the kernel bits in that patch series, not the link. It's possible that if you go look at the threads about those kernel patches you're find out the reason. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features 2011-08-25 19:04 ` Ben Greear 2011-08-26 16:41 ` David Miller @ 2011-08-26 18:41 ` Michał Mirosław 2011-08-26 23:17 ` Jeff Kirsher 1 sibling, 1 reply; 8+ messages in thread From: Michał Mirosław @ 2011-08-26 18:41 UTC (permalink / raw) To: Ben Greear; +Cc: netdev, David S. Miller, Ben Hutchings, Jeff Kirsher On Thu, Aug 25, 2011 at 12:04:40PM -0700, Ben Greear wrote: > On 06/22/2011 09:04 AM, Michał Mirosław wrote: > >v3 of a feature handling cleanup and extension series. For testing, you > >might want user-space ethtool patched with: > >http://patchwork.ozlabs.org/patch/96374/ > It looks like this is not in net-next yet...any hope of this > going in soon? It's because the series depends on finishing conversions of all drivers to ndo_fix/set_features. e1000e, igbvf, ixgb, ixgbevf are pending. BTW, Jeff, what is the status of those conversions? Last version of ixgbe patch from Donald Skidmore (sent about a month ago) was mostly ready IIUC. Best Regards, Michał Mirosław ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH v3 00/12] Cleanup and extension of netdev features 2011-08-26 18:41 ` Michał Mirosław @ 2011-08-26 23:17 ` Jeff Kirsher 0 siblings, 0 replies; 8+ messages in thread From: Jeff Kirsher @ 2011-08-26 23:17 UTC (permalink / raw) To: Michał Mirosław Cc: Ben Greear, netdev@vger.kernel.org, David S. Miller, Ben Hutchings [-- Attachment #1: Type: text/plain, Size: 1143 bytes --] On Fri, 2011-08-26 at 11:41 -0700, Michał Mirosław wrote: > On Thu, Aug 25, 2011 at 12:04:40PM -0700, Ben Greear wrote: > > On 06/22/2011 09:04 AM, Michał Mirosław wrote: > > >v3 of a feature handling cleanup and extension series. For testing, you > > >might want user-space ethtool patched with: > > >http://patchwork.ozlabs.org/patch/96374/ > > It looks like this is not in net-next yet...any hope of this > > going in soon? > > It's because the series depends on finishing conversions of all drivers > to ndo_fix/set_features. e1000e, igbvf, ixgb, ixgbevf are pending. > > BTW, Jeff, what is the status of those conversions? Last version of ixgbe > patch from Donald Skidmore (sent about a month ago) was mostly ready IIUC. > > Best Regards, > Michał Mirosław e1000e patch just completed testing, I will be pushing that tonight. ixgbe got pushed back in June, but there some suggested changes you had made with Don and that patch has been in/out of testing due to issues found. It also appears that the ixgbevf patch has completed testing. The only remaining patch which is left to complete is igbvf. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-08-26 23:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1308758435.git.mirq-linux@rere.qmqm.pl>
2011-06-22 23:11 ` [RFT PATCH v3 00/12] Cleanup and extension of netdev features Ben Greear
2011-06-27 14:21 ` Michał Mirosław
2011-08-25 19:04 ` Ben Greear
2011-08-26 16:41 ` David Miller
2011-08-26 16:43 ` Ben Greear
2011-08-26 16:47 ` David Miller
2011-08-26 18:41 ` Michał Mirosław
2011-08-26 23:17 ` Jeff Kirsher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).