From: Joe Perches <joe@perches.com>
To: Sony Chacko <sony.chacko@qlogic.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Dept_NX_Linux_NIC_Driver <Dept_NX_Linux_NIC_Driver@qlogic.com>,
Manish chopra <Manish.Chopra@qlogic.com>
Subject: Re: [PATCH net-next 2/5] qlcnic: Change debug messages in loopback path
Date: Mon, 29 Aug 2011 20:00:37 -0700 [thread overview]
Message-ID: <1314673237.6852.53.camel@Joe-Laptop> (raw)
In-Reply-To: <1314658231-30735-2-git-send-email-sony.chacko@qlogic.com>
On Mon, 2011-08-29 at 15:50 -0700, Sony Chacko wrote:
> From: Manish chopra <Manish.Chopra@qlogic.com>
> Added more debug messages while loopback test in progress
[]
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
[]
> @@ -736,13 +736,18 @@ static int qlcnic_do_lb_test(struct qlcnic_adapter *adapter)
[]
> + if (mode != QLCNIC_ILB_MODE) {
> + dev_warn(&adapter->pdev->dev,
> + "WARNING: Please make sure external"
> + "loopback connector is plugged in\n");
It's better to avoid splitting format strings.
This emits "externalloopback" instead of "external loopback".
> -static void dump_skb(struct sk_buff *skb)
> +static void dump_skb(struct sk_buff *skb, struct qlcnic_adapter *adapter)
> {
> int i;
> unsigned char *data = skb->data;
>
> printk(KERN_INFO "\n");
> for (i = 0; i < skb->len; i++) {
> - printk(KERN_INFO "%02x ", data[i]);
> + QLCDB(adapter, DRV, "%02x ", data[i]);
print_hex_dump
next prev parent reply other threads:[~2011-08-30 3:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 22:50 [PATCH net-next 1/5] qlcnic: detect fan failure Sony Chacko
2011-08-29 22:50 ` [PATCH net-next 2/5] qlcnic: Change debug messages in loopback path Sony Chacko
2011-08-30 3:00 ` Joe Perches [this message]
2011-08-29 22:50 ` [PATCH net-next 3/5] qlcnic: Add FLT entry for CO cards FW image region Sony Chacko
2011-08-29 22:50 ` [PATCH net-next 4/5] qlcnic: fix cdrp race condition Sony Chacko
2011-08-29 22:50 ` [PATCH net-next 5/5] qlcnic: add beacon test support Sony Chacko
2011-08-29 22:50 ` [PATCH net-next 0/5] qlcnic: Bug fixes Sony Chacko
2011-08-30 2:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314673237.6852.53.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=Manish.Chopra@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox