Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [Bug 42012] New: regression on 2.6.39.3 with socket/bind; still there in 3.0.4
Date: Tue, 30 Aug 2011 21:44:19 +0200	[thread overview]
Message-ID: <1314733459.2556.10.camel@edumazet-laptop> (raw)
In-Reply-To: <1314731803.2556.4.camel@edumazet-laptop>

Le mardi 30 août 2011 à 21:16 +0200, Eric Dumazet a écrit :
> Le mardi 30 août 2011 à 14:07 -0400, David Miller a écrit :
> > From: Eric Dumazet <eric.dumazet@gmail.com>
> > Date: Tue, 30 Aug 2011 18:11:48 +0200
> > 
> > > Yep, we should relax the check and accept AF_UNSPEC.
> > 
> > I guess we'll have to do this, but I just can't bring myself to accept
> > that we can just do zero validation of what the user is passing us,
> > see an AF_UNSPEC, and say "yeah it's fine to assume there's an ipv4
> > address in there."
> 
> I couldnt accept it either ;)
> 
> By the way, if we accept it, strace() will probably still print binary
> blob instead of the IP address (not necessarily ANY address ?)
> 
> connect ( AF_UNSPEC ) has special semantic, but AFAIK, bind (AF_UNSPEC)
> only brings some mixed results : FreeBSD was accepting it in old
> versions it seems. I guess I should try current FreeBSD versions.
> 

Status on FreeBSD 8.1-RELEASE

bind(AF_UNSPEC) is accepted (converted to AF_INET), only with a 0.0.0.0
address.

Following code works :

struct sockaddr_in addr;
fd = socket(PF_INET, SOCK_STREAM, 0);
memset(&addr, 0, sizeof(addr))
bind(fd, (struct sockaddr *)&addr, sizeof(addr)); -> 0

If tried on ipv6 sockets, it doesnt work : bind() returns -1, errno=47

struct sockaddr_in6 addr;
fd = socket(PF_INET6, SOCK_STREAM, 0);
memset(&addr, 0, sizeof(addr))
bind(fd, (struct sockaddr *)&addr, sizeof(addr)); -> -1 errno=47

  reply	other threads:[~2011-08-30 19:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 15:47 Fw: [Bug 42012] New: regression on 2.6.39.3 with socket/bind; still there in 3.0.4 Stephen Hemminger
2011-08-30 16:11 ` Eric Dumazet
2011-08-30 18:07   ` David Miller
2011-08-30 19:16     ` Eric Dumazet
2011-08-30 19:44       ` Eric Dumazet [this message]
2011-08-30 19:52         ` David Miller
2011-08-30 20:00           ` Eric Dumazet
2011-08-30 20:19             ` Eric Dumazet
2011-08-30 22:57               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314733459.2556.10.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox