From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [patch net-next-2.6 1/2] net: allow to change carrier via sysfs Date: Wed, 31 Aug 2011 21:12:17 +0100 Message-ID: <1314821537.3274.24.camel@bwh-desktop> References: <1314715608-978-1-git-send-email-jpirko@redhat.com> <1314715608-978-2-git-send-email-jpirko@redhat.com> <20110831082655.GB2010@minipsycho.brq.redhat.com> <20110831084511.GD2010@minipsycho.brq.redhat.com> <4E5E939C.5000009@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jiri Pirko , =?UTF-8?Q?Micha=C5=82_Miros=C5=82aw?= , netdev@vger.kernel.org, davem@davemloft.net, eric.dumazet@gmail.com, shemminger@vyatta.com To: Nicolas de =?ISO-8859-1?Q?Peslo=FCan?= Return-path: Received: from exchange.solarflare.com ([216.237.3.220]:1086 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753882Ab1HaUMV convert rfc822-to-8bit (ORCPT ); Wed, 31 Aug 2011 16:12:21 -0400 In-Reply-To: <4E5E939C.5000009@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2011-08-31 at 22:03 +0200, Nicolas de Peslo=C3=BCan wrote: > Le 31/08/2011 10:45, Jiri Pirko a =C3=A9crit : >=20 > >>>> Do you expect drivers using implementation different than just c= alling > >>>> netif_carrier_on/off? Or is it supposed to also e.g. power down = PHYs? > >>> Yes, generally it can be used also for en/disable phy, for testin= g > >>> purposes if hw and driver would support it. > >> > >> I'd like to see this working for GRE tunnel devices (for keepalive > >> daemon to be able to indicate to routing daemons whether tunnel is > >> really working) - implementation would be identical to dummy's cas= e. > >> Should I prepare a patch or can I leave it to you? > > > > Ok, I can include it to this patchset (I'm going to repost first pa= tch > > anyway) >=20 > Can't we assume that the dummy's case is the default behavior and > register this default=20 > ndo_change_carrier callback for every device ? You have got to be joking. No device driver that has real link monitoring should use this implementation. [...] > If someone is not confident with this default callback registered for > all device, at least, we can=20 > put this code in a common place, so that a driver willing to use it > doesn't need to have its own=20 > version of it. I agree that this might be useful in some other software devices, though. Ben. --=20 Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.