From: Ben Hutchings <bhutchings@solarflare.com>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: Uncook tg3 regdump output
Date: Wed, 31 Aug 2011 23:25:30 +0100 [thread overview]
Message-ID: <1314829530.3274.42.camel@bwh-desktop> (raw)
In-Reply-To: <1314842557-32247-1-git-send-email-mcarlson@broadcom.com>
On Wed, 2011-08-31 at 19:02 -0700, Matt Carlson wrote:
> tg3 devices have changed a lot since the bcm5700 days. Register blocks
> have been added, removed and redefined. The existing tg3 register dump
> code has not kept up.
>
> This patch changes the tg3_dump_regs() function to be more simplistic.
> Rather than attempting to locate where meaningful data is, it will
> instead print the registers as 32-bit values, omitting all registers
> that have a value of zero. By performing the output this way, we hope
> to future-proof the interface.
[...]
Applied.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-08-31 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 2:02 [PATCH] ethtool: Uncook tg3 regdump output Matt Carlson
2011-08-31 22:25 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314829530.3274.42.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox