From: Ben Hutchings <bhutchings@solarflare.com>
To: Yaniv Rosner <yanivr@broadcom.com>
Cc: davem@davemloft.net, eilong@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 6/6] bnx2x: Fix ethtool advertisement
Date: Tue, 06 Sep 2011 16:19:52 +0100 [thread overview]
Message-ID: <1315322392.2788.2.camel@bwh-desktop> (raw)
In-Reply-To: <1315291645.28564.20.camel@lb-tlvb-dmitry>
On Tue, 2011-09-06 at 09:47 +0300, Yaniv Rosner wrote:
> Enable changing advertisement settings via ethtool and fix
> flow-control advertisement when autoneg flow-control is disabled.
[...]
> diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
> index f74582a..42c7be1 100644
> --- a/drivers/net/bnx2x/bnx2x_main.c
> +++ b/drivers/net/bnx2x/bnx2x_main.c
> @@ -2125,6 +2125,12 @@ static int bnx2x_set_spio(struct bnx2x *bp, int spio_num, u32 mode)
> void bnx2x_calc_fc_adv(struct bnx2x *bp)
> {
> u8 cfg_idx = bnx2x_get_link_cfg_idx(bp);
> + if (bp->link_params.req_flow_ctrl[cfg_idx] != BNX2X_FLOW_CTRL_AUTO) {
> + bp->port.advertising[cfg_idx] &= ~(ADVERTISED_Asym_Pause |
> + ADVERTISED_Pause);
> + return;
> + }
[...]
I think you should still advertise the flow control behaviour you want,
even if you will override the result of autonegotiation.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-09-06 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 6:47 [PATCH net 6/6] bnx2x: Fix ethtool advertisement Yaniv Rosner
2011-09-06 15:19 ` Ben Hutchings [this message]
2011-09-07 9:39 ` Yaniv Rosner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315322392.2788.2.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=yanivr@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).