From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy King <acking@vmware.com>
Subject: Re: [PATCH 0/1] VM Sockets for Linux upstreaming
Date: Tue, 5 Feb 2013 09:02:29 -0800 (PST)
Message-ID: <1315741351.2964541.1360083749055.JavaMail.root@vmware.com>
References: <51113637.7070209@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: pv-drivers@vmware.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	gregkh@linuxfoundation.org, davem@davemloft.net
To: Gerd Hoffmann <kraxel@redhat.com>
Return-path: <virtualization-bounces@lists.linux-foundation.org>
In-Reply-To: <51113637.7070209@redhat.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
List-Id: netdev.vger.kernel.org

Hi Gerd,

> Some separation still needs to be done:
> 
>   CC [M]  net/vmw_vsock/af_vsock.o
> In file included from
> /home/kraxel/projects/linux/net/vmw_vsock/af_vsock.c:102:0:
> /home/kraxel/projects/linux/net/vmw_vsock/af_vsock.h:21:33: fatal
> error:
> linux/vmw_vmci_defs.h: No such file or directory
> compilation terminated.
> make[4]: *** [net/vmw_vsock/af_vsock.o] Error 1

Oops, you're right, it really shouldn't need that header.  Sorry
about that, let me rip that out.

> Module deps are a bit bogous too:
> 
> vmw_vsock_vmci_transport    26162  0
> vsock                  34481  1 vmw_vsock_vmci_transport
> vmw_vmci               61602  2 vsock,vmw_vsock_vmci_transport
> 
> Only vmw_vsock_vmci_transport should have a vmw_vmci dependency, not
> vsock ...

Agreed, that's not right, I'll fix that too.

> Nevertheless this should be good enough to start hacking up a virtio
> prototype.

Great!

Thanks!
- Andy