From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [GIT] Networking Date: Sun, 18 Sep 2011 21:46:04 +0200 Message-ID: <1316375164.31335.18.camel@edumazet-laptop> References: <20110918.022125.1554085675403900813.davem@davemloft.net> <20110918192333.GA1641@x4.trippels.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Linus Torvalds , David Miller , akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Markus Trippelsdorf Return-path: In-Reply-To: <20110918192333.GA1641@x4.trippels.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Le dimanche 18 septembre 2011 =C3=A0 21:23 +0200, Markus Trippelsdorf a =C3=A9crit : > On 2011.09.18 at 11:06 -0700, Linus Torvalds wrote: > > 2011/9/17 David Miller : > > > > > > dpward (2): > > > net: Make flow cache namespace-aware > > > net: Handle different key sizes between address families in = flow cache > > > > > > nhorman (1): > > > net: don't clear IFF_XMIT_DST_RELEASE in ether_setup > > > > > > rajan.aggarwal85@gmail.com (1): > > > net/can/af_can.c: Change del_timer to del_timer_sync > >=20 > > Guys, if somebody has such a broken email setup that they don't eve= n > > show their own name, don't take patches from them. > >=20 > > If you cannot even set up email sanely, there is zero reason to > > believe that the patch should be good. And if the patch is trivial = and > > you want to take it despite the source of the patch being crap, ple= ase > > spend the five seconds to fix it up. > >=20 > > Proper names are part of the commit message. Don't make it look lik= e > > crap. I get ugly flashbacks to SVN or CVS when I see stuff like thi= s. > > Don't do it. >=20 > Plus commit 946cedccbd73874 breaks the build: >=20 > LD init/built-in.o > LD .tmp_vmlinux1 > net/built-in.o:sysctl_net.c:function tcp_v4_conn_request: error: unde= fined reference to 'cookie_v4_init_sequence' > make: *** [.tmp_vmlinux1] Error 1 >=20 > commit 946cedccbd7387488d2cee5da92cdfeb28d2e670 > Author: Eric Dumazet > Date: Tue Aug 30 03:21:44 2011 +0000 >=20 > tcp: Change possible SYN flooding messages >=20 > "Possible SYN flooding on port xxxx " messages can fill logs on s= ervers. >=20 > Change logic to log the message only once per listener, and add t= wo new > SNMP counters to track : >=20 > TCPReqQFullDoCookies : number of times a SYNCOOKIE was replied to= client >=20 > TCPReqQFullDrop : number of times a SYN request was dropped becau= se > syncookies were not enabled. >=20 > Based on a prior patch from Tom Herbert, and suggestions from Dav= id. >=20 >=20 Oh well, trying to remove those ugly #ifdef was not so easy. I'll cook a patch, thanks for the report