From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: "Allan, Bruce W" <bruce.w.allan@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Vogel, Jack" <jack.vogel@intel.com>
Subject: Re: MSI-X vector count on 82754L
Date: Mon, 19 Sep 2011 16:56:09 -0700 [thread overview]
Message-ID: <1316476569.2184.13.camel@jtkirshe-mobl> (raw)
In-Reply-To: <CACqU3MUfQn_r2oJ+ptuzYhkkUoucfL_NTMnHoCa0+TouP0s0kA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2229 bytes --]
On Sun, 2011-09-18 at 22:34 -0700, Arnaud Lacombe wrote:
> [fixing address of the netdev@ list, sorry - A.]
>
> On Mon, Sep 19, 2011 at 1:31 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> > Hi folks,
> >
> > In:
> >
> > commit 4662e82b2cb41c60826e50474dd86dd5c6372b0c
> > Author: Bruce Allan <bruce.w.allan@intel.com>
> > Date: Tue Aug 26 18:37:06 2008 -0700
> >
> > e1000e: add support for new 82574L part
> >
> > This new part has the same feature set as previous parts with the addition
> > of MSI-X support.
> >
> > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> >
> > MSI-X support was added to the e1000e driver, later on slightly reworked by:
> >
> > commit 8e86acd7d5968e08b3e1604e685a8c45f6fd7f40
> > Author: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Date: Mon Aug 2 14:27:23 2010 +0000
> >
> > e1000e: Fix irq_synchronize in MSI-X case
> >
> > Based on original patch/work from Jean Delvare <jdelvare@suse.de>
> > Synchronize all IRQs when in MSI-X IRQ mode.
> >
> > Jean's original patch hard coded the sync with the 3 possible vectors,
> > this patch incorporates more flexibility for the future and aligns
> > with how igb stores the number of vectors into the adapter structure.
> >
> > CC: Jean Delvare <jdelvare@suse.de>
> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
> > Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> > [It is unclear to what "Jean" does this commit log refers to, as the
> > support MSI-X was added Bruce, anyway...]
> >
> > Why only 3 vectors are used when both the product brief and the
> > datasheet advertise up to 5 MSI-X vector usable by the chip ? That is
> > 2*RX + 2*TX.
> >
> > Thanks in advance,
> > - Arnaud
> >
The e1000e driver is only a single queue driver so it does not need more
than 3 vectors, that is the reason we only use the 3 vectors.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2011-09-19 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACqU3MVZ6GT7hNKsnWq-otxsX4TDtTi8qYPG=4gYn=cBF7-tJg@mail.gmail.com>
2011-09-19 5:34 ` MSI-X vector count on 82754L Arnaud Lacombe
2011-09-19 23:56 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316476569.2184.13.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=jack.vogel@intel.com \
--cc=lacombar@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).