netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: netdev@vger.kernel.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] macvtap: fix warning due to use of uninitialised var
Date: Tue, 20 Sep 2011 11:48:11 +0100	[thread overview]
Message-ID: <1316515691-1833-1-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <20110920091724.GA11100@elgon.mountain>

d1b08284ade "macvtap: convert to SKB paged frag API." accidentally dropped the
initialisation of a variable leading to:
	drivers/net/macvtap.c:509:5: warning: ‘f’ may be used uninitialized
		in this function [-Wuninitialized]

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 drivers/net/macvtap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 7c3f84a..5beda89 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -503,6 +503,7 @@ static int zerocopy_sg_from_iovec(struct sk_buff *skb, const struct iovec *from,
 		skb->truesize += len;
 		atomic_add(len, &skb->sk->sk_wmem_alloc);
 		while (len) {
+			f = &skb_shinfo(skb)->frags[i];
 			__skb_fill_page_desc(
 				skb, i, page[i],
 				base & ~PAGE_MASK,
-- 
1.7.2.5

      parent reply	other threads:[~2011-09-20 10:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20  9:17 macvtap: convert to SKB paged frag API Dan Carpenter
2011-09-20 10:05 ` Ian Campbell
2011-09-20 10:48 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316515691-1833-1-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).