public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rasesh Mody <rmody@brocade.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	adapter_linux_open_src_team@brocade.com,
	Gurunatha Karaje <gkaraje@brocade.com>
Subject: Re: [net-next 6/7] bna: Add Callback to Fix RXQ Stop
Date: Fri, 23 Sep 2011 19:38:31 -0700	[thread overview]
Message-ID: <1316831912.28330.19.camel@Joe-Laptop> (raw)
In-Reply-To: <1316830458-24773-7-git-send-email-rmody@brocade.com>

On Fri, 2011-09-23 at 19:14 -0700, Rasesh Mody wrote:
> diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
[]
> @@ -956,6 +956,27 @@ bnad_cb_tx_cleanup(struct bnad *bnad, struct bna_tx *tx)
>  }
>  
>  static void
> +bnad_cb_rx_stall(struct bnad *bnad, struct bna_rx *rx)
> +{
> +	struct bnad_rx_info *rx_info = (struct bnad_rx_info *)rx->priv;
> +	struct bna_ccb *ccb;
> +	struct bnad_rx_ctrl *rx_ctrl;
> +	int i;
> +
> +	for (i = 0; i < BNAD_MAX_RXP_PER_RX; i++) {
> +		rx_ctrl = &rx_info->rx_ctrl[i];
> +		ccb = rx_ctrl->ccb;
> +		if (!ccb)
> +			continue;
> +
> +	clear_bit(BNAD_RXQ_POST_OK, &ccb->rcb[0]->flags);
> +
> +	if (ccb->rcb[1])
> +		clear_bit(BNAD_RXQ_POST_OK, &ccb->rcb[1]->flags);

misleading indentation.  Please add a tab.

> +	}
> +}
> +

  reply	other threads:[~2011-09-24  2:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-24  2:14 [net-next 0/7] bna: H/W enablement and update driver version to 3.0.2.2 Rasesh Mody
2011-09-24  2:14 ` [net-next 1/7] bna: Brocade 1860 IOC PLL, Reg Defs and ASIC Mode Changes Rasesh Mody
2011-09-24  2:30   ` Joe Perches
2011-09-26 16:43     ` Rasesh Mody
2011-09-24  2:14 ` [net-next 2/7] bna: Capability Map and MFG Block Changes for New HW Rasesh Mody
2011-09-24  2:14 ` [net-next 3/7] bna: Implement FW Download " Rasesh Mody
2011-09-24  2:14 ` [net-next 4/7] bna: Brocade 1860 HW Enablement Rasesh Mody
2011-09-24  2:14 ` [net-next 5/7] bna: PLL Init Fix and Add Stats Attributes Rasesh Mody
2011-09-24  2:14 ` [net-next 6/7] bna: Add Callback to Fix RXQ Stop Rasesh Mody
2011-09-24  2:38   ` Joe Perches [this message]
2011-09-24  2:14 ` [net-next 7/7] bna: Driver Version changed to 3.0.2.2 Rasesh Mody
  -- strict thread matches above, loose matches on Subject: below --
2011-09-26 21:12 [net-next 0/7] bna: H/W enablement and update driver version " Rasesh Mody
2011-09-26 21:12 ` [net-next 6/7] bna: Add Callback to Fix RXQ Stop Rasesh Mody
2011-09-27 20:39 [net-next 0/7] bna: H/W enablement and update driver version to 3.0.2.2 Rasesh Mody
2011-09-27 20:39 ` [net-next 6/7] bna: Add Callback to Fix RXQ Stop Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316831912.28330.19.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=adapter_linux_open_src_team@brocade.com \
    --cc=davem@davemloft.net \
    --cc=gkaraje@brocade.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmody@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox