From: jamal <hadi@cyberus.ca>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, "Jerry Chu" <hkchu@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
"Jim Gettys" <jg@freedesktop.org>,
"Dave Taht" <dave.taht@gmail.com>
Subject: Re: [PATCH] tcp: ECN blackhole should not force quickack mode
Date: Sun, 25 Sep 2011 21:07:46 -0400 [thread overview]
Message-ID: <1316999266.1865.35.camel@mojatatu> (raw)
In-Reply-To: <1316978684.2531.7.camel@edumazet-laptop>
On Sun, 2011-09-25 at 21:24 +0200, Eric Dumazet wrote:
>
> So we have somewhere a box that mask the TOS bits. This is a well known
> effect on some networks, unfortunately.
ok
> The 'linux funny extension' is wrong in this case, since I have no
> retransmits, no losses, yet my laptop is in quickack mode (it sends an
> ACK for every incoming data packet), because you assumed receiving a
> packet with no ECT bits means this packet was a retransmit.
No objection from me - only one corner case i can think of is if
expected behavior happens and the first data packet was a retransmit
(i.e you wouldnt have seen an ECT which you need for your heuristic),
but that is probably not a big a deal.
In regards to the 'linux funny extension' - this was a brilliant idea
in my opinion back then from Alexey; lots of discussions happened but
I cant remember if it made it in some RFC or not (I will try to search
some old archives).
cheers,
jamal
next prev parent reply other threads:[~2011-09-26 1:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 6:02 [PATCH] tcp: ECN blackhole should not force quickack mode Eric Dumazet
2011-09-23 17:47 ` David Miller
2011-09-23 19:17 ` Ilpo Järvinen
2011-09-24 0:55 ` Jamal Hadi Salim
2011-09-25 19:24 ` Eric Dumazet
2011-09-26 1:07 ` jamal [this message]
2011-09-26 1:13 ` jamal
2011-09-26 8:26 ` Eric Dumazet
2011-09-26 12:00 ` jamal
2011-09-26 12:44 ` Eric Dumazet
2011-09-27 4:59 ` David Miller
2011-09-27 6:00 ` [PATCH net-next] tcp: unalias tcp_skb_cb flags and ip_dsfield Eric Dumazet
2011-09-27 6:20 ` David Miller
2011-09-27 7:37 ` Christoph Paasch
2011-09-27 8:01 ` Eric Dumazet
2011-09-27 8:08 ` David Miller
2011-09-27 8:38 ` Christoph Paasch
2011-09-27 9:23 ` Eric Dumazet
2011-09-27 9:28 ` Christoph Paasch
2011-09-27 9:40 ` Eric Dumazet
2011-09-27 9:51 ` [PATCH net-next] tcp: rename tcp_skb_cb flags Eric Dumazet
2011-09-27 17:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316999266.1865.35.camel@mojatatu \
--to=hadi@cyberus.ca \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hkchu@google.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=jg@freedesktop.org \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).