From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] tcp: properly release md5sig_pool references
Date: Mon, 26 Sep 2011 08:26:09 +0200 [thread overview]
Message-ID: <1317018369.2853.16.camel@edumazet-laptop> (raw)
In-Reply-To: <4E7FE4DD.5070804@intel.com>
Le lundi 26 septembre 2011 à 10:35 +0800, Yan, Zheng a écrit :
> tcp_v4_md5_do_add() increases use count of md5sig_pool by one for
> each tcp md5sig peer, so we should call tcp_free_md5sig_pool() for
> each peer when destroying the socket.
>
> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
As managing the use count is rather expensive, I think it would be
better to hold a single reference instead of multiple ones ?
next prev parent reply other threads:[~2011-09-26 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 2:35 [PATCH] tcp: properly release md5sig_pool references Yan, Zheng
2011-09-26 6:26 ` Eric Dumazet [this message]
2011-09-26 8:11 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317018369.2853.16.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox