From: Eric Dumazet <eric.dumazet@gmail.com>
To: brenohl@br.ibm.com
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: Remove sleep at .ndo_get_stats
Date: Mon, 26 Sep 2011 22:28:55 +0200 [thread overview]
Message-ID: <1317068935.2796.12.camel@edumazet-laptop> (raw)
In-Reply-To: <1317067863-11706-1-git-send-email-brenohl@br.ibm.com>
Le lundi 26 septembre 2011 à 17:11 -0300, brenohl@br.ibm.com a écrit :
> Currently ehea ndo_get_stats can sleep in two places, in a hcall
> and in a GFP_KERNEL alloc, which is not correct.
> This patch creates a delayed workqueue that grabs the information each 1
> sec from the hardware, and place it into the device structure, so that,
> .ndo_get_stats quickly returns the device structure statistics block.
>
> Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
> ---
Seems good, thanks
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2011-09-26 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 14:10 [PATCH net-next] ehea: Remove sleep at .ndo_get_stats brenohl
2011-09-22 15:14 ` Eric Dumazet
2011-09-26 17:15 ` [PATCH] " brenohl
2011-09-26 18:02 ` Eric Dumazet
2011-09-26 18:56 ` Breno Leitao
2011-09-26 19:21 ` brenohl
2011-09-26 19:42 ` Eric Dumazet
2011-09-26 20:11 ` brenohl
2011-09-26 20:28 ` Eric Dumazet [this message]
2011-09-27 4:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317068935.2796.12.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=brenohl@br.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox