From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Greg Rose <gregory.v.rose@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com,
Jiri Pirko <jpirko@redhat.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 2/8] ixgbevf: Fix broken trunk vlan
Date: Wed, 28 Sep 2011 23:30:10 -0700 [thread overview]
Message-ID: <1317277816-6024-3-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1317277816-6024-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Greg Rose <gregory.v.rose@intel.com>
Changes to clean up the vlan rx path broke trunk vlan. Trunk vlans in
a VF driver are those set using:
"ip link set <pfdev> vf <n> <vlanid>"
Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
CC: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index d72905b..4930c46 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -293,12 +293,10 @@ static void ixgbevf_receive_skb(struct ixgbevf_q_vector *q_vector,
{
struct ixgbevf_adapter *adapter = q_vector->adapter;
bool is_vlan = (status & IXGBE_RXD_STAT_VP);
+ u16 tag = le16_to_cpu(rx_desc->wb.upper.vlan);
- if (is_vlan) {
- u16 tag = le16_to_cpu(rx_desc->wb.upper.vlan);
-
+ if (is_vlan && test_bit(tag, adapter->active_vlans))
__vlan_hwaccel_put_tag(skb, tag);
- }
if (!(adapter->flags & IXGBE_FLAG_IN_NETPOLL))
napi_gro_receive(&q_vector->napi, skb);
--
1.7.6.2
next prev parent reply other threads:[~2011-09-29 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 6:30 [net-next 0/8][pull request] Intel Wired LAN Drivers Update Jeff Kirsher
2011-09-29 6:30 ` [net-next 1/8] e1000: don't enable dma receives until after dma address has been setup Jeff Kirsher
2011-09-29 6:30 ` Jeff Kirsher [this message]
2011-09-29 6:30 ` [net-next 3/8] ixgbe: Cleanup q_vector interrupt throttle rate logic Jeff Kirsher
2011-09-29 6:30 ` [net-next 4/8] ixgbe: disable LLI for FCoE Jeff Kirsher
2011-09-29 6:30 ` [net-next 5/8] ixgbe: update {P}FC thresholds to account for X540 and loopback Jeff Kirsher
2011-09-29 6:30 ` [net-next 6/8] ixgbe add thermal sensor support for x540 hardware Jeff Kirsher
2011-09-29 6:30 ` [net-next 7/8] ixgbe: cleanup ixgbe_setup_gpie() for X540 Jeff Kirsher
2011-09-29 6:30 ` [net-next 8/8] ixgbe: add ECC warning for legacy interrupts Jeff Kirsher
2011-09-29 19:48 ` [net-next 0/8][pull request] Intel Wired LAN Drivers Update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317277816-6024-3-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).