From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 05/11] ixgbe: fix driver version initialization in firmware
Date: Thu, 29 Sep 2011 22:24:45 -0700 [thread overview]
Message-ID: <1317360291-5576-6-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1317360291-5576-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
This patch fixes an issue with storing the driver version for the
firmware. If the os does not support the particular firmware
management tools, the firmware requires a driver version to be written
as 0xFFFFFFFF rather than the actual driver version.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index ed92272..1a3b91f 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7587,10 +7587,12 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,
ixgbe_vf_configuration(pdev, (i | 0x10000000));
}
- /* Inform firmware of driver version */
+ /* firmware requires driver version to be 0xFFFFFFFF
+ * since os does not support feature
+ */
if (hw->mac.ops.set_fw_drv_ver)
- hw->mac.ops.set_fw_drv_ver(hw, MAJ, MIN, BUILD,
- FW_CEM_UNUSED_VER);
+ hw->mac.ops.set_fw_drv_ver(hw, 0xFF, 0xFF, 0xFF,
+ 0xFF);
/* add san mac addr to netdev */
ixgbe_add_sanmac_netdev(netdev);
--
1.7.6.2
next prev parent reply other threads:[~2011-09-30 5:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 5:24 [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-09-30 5:24 ` [net-next 01/11] e1000e: make function tables const Jeff Kirsher
2011-09-30 5:24 ` [net-next 02/11] ixgbe: prevent link checks while resetting Jeff Kirsher
2011-09-30 5:24 ` [net-next 03/11] ixgbe: clear the data field in ixgbe_read_i2c_byte_generic Jeff Kirsher
2011-09-30 5:24 ` [net-next 04/11] ixgbe: remove return code for functions that always return 0 Jeff Kirsher
2011-09-30 5:24 ` Jeff Kirsher [this message]
2011-09-30 5:24 ` [net-next 06/11] ixgbe: add support for new 82599 device Jeff Kirsher
2011-09-30 5:24 ` [net-next 07/11] ixgbe: send MFLCN to ethtool Jeff Kirsher
2011-09-30 5:24 ` [net-next 08/11] ixgbe: do not disable flow control in ixgbe_check_mac_link Jeff Kirsher
2011-09-30 5:24 ` [net-next 09/11] ixgbe: get pauseparam autoneg Jeff Kirsher
2011-09-30 5:24 ` [net-next 10/11] ixgbe: remove instances of ixgbe_phy_aq for 82598 and 82599 Jeff Kirsher
2011-09-30 5:24 ` [net-next 11/11] ixgbe: allow eeprom writes via ethtool Jeff Kirsher
2011-09-30 13:52 ` Ben Hutchings
2011-09-30 18:35 ` [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317360291-5576-6-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).