From: Ben Hutchings <bhutchings@solarflare.com>
To: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Cc: netdev@vger.kernel.org,
Dept_NX_Linux_NIC_Driver <Dept_NX_Linux_NIC_Driver@qlogic.com>
Subject: Re: [PATCH ethtool 3/3] ethtool: add ETHTOOL_{G,S}CHANNEL support.
Date: Tue, 04 Oct 2011 23:36:39 +0100 [thread overview]
Message-ID: <1317767799.2751.33.camel@bwh-desktop> (raw)
In-Reply-To: <1317766902.2751.25.camel@bwh-desktop>
On Tue, 2011-10-04 at 23:21 +0100, Ben Hutchings wrote:
> On Tue, 2011-09-20 at 03:31 -0700, Sucheta Chakraborty wrote:
> > Used to configure number of rx and tx rings.
> > Reqd. man page changes are included.
> [...]
> > @@ -754,6 +764,24 @@ lB l.
> > Specify the location/ID to insert the rule. This will overwrite
> > any rule present in that location and will not go through any
> > of the rule ordering process.
> > +.TP
> > +.B \-l \-\-show\-channels
> > +Queries the specified network device for channel parameter information.
> > +.TP
> > +.B \-L \-\-set\-channels
> > +Changes the channel parameters of the specified network device.
>
> I think the manual page needs to explain briefly what is meant by a
> channel. (So should ethtool.h, really!)
[...]
Perhaps something like this:
.TP
.B \-l \-\-show\-channels
Queries the specified network device for the numbers of channels it has.
A channel is an IRQ and the set of queues that can trigger that IRQ.
.TP
.B \-L \-\-set\-channels
Changes the numbers of channels of the specified network device.
.TP
.BI rx \ N
Changes the number of channels with only receive queues.
.TP
.BI tx \ N
Changes the number of channels with only transmit queues.
.TP
.BI other \ N
Changes the number of channels used only for other purposes e.g. link
interrupts or SR-IOV co-ordination.
.TP
.BI combined \ N
Changes the number of multi-purpose channels.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-10-04 22:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 10:31 [PATCH 0/3] ethtool: Features added Sucheta Chakraborty
2011-09-20 10:31 ` [PATCH ethtool 1/3] ethtool: file ethtool-copy.h update Sucheta Chakraborty
2011-10-04 22:09 ` Ben Hutchings
2011-09-20 10:31 ` [PATCH ethtool 2/3] ethtool: add support for external loopback Sucheta Chakraborty
2011-10-04 22:12 ` Ben Hutchings
2011-09-20 10:31 ` [PATCH ethtool 3/3] ethtool: add ETHTOOL_{G,S}CHANNEL support Sucheta Chakraborty
2011-10-04 22:21 ` Ben Hutchings
2011-10-04 22:36 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317767799.2751.33.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sucheta.chakraborty@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).