From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jon Mason <jdmason@kudzu.us>
Subject: Re: [PATCH 1/8] vxge: convert to SKB paged frag API.
Date: Thu, 6 Oct 2011 08:05:56 +0100 [thread overview]
Message-ID: <1317884756.24742.13.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <CAHXqBFKX5eojLMhT1MW1inAUH9cfVne4-rhDQYSLsUh-OTzuPQ@mail.gmail.com>
On Wed, 2011-10-05 at 22:03 +0100, Michał Mirosław wrote:
> 2011/10/5 Ian Campbell <ian.campbell@citrix.com>:
> [...]
> > --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
> > +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
> > @@ -923,9 +923,9 @@ vxge_xmit(struct sk_buff *skb, struct net_device *dev)
> > if (!frag->size)
> > continue;
> >
> > - dma_pointer = (u64) pci_map_page(fifo->pdev, frag->page,
> > - frag->page_offset, frag->size,
> > - PCI_DMA_TODEVICE);
> > + dma_pointer = (u64)skb_frag_dma_map(&fifo->pdev->dev, frag,
> > + 0, frag->size,
> > + PCI_DMA_TODEVICE);
>
> This should be DMA_TO_DEVICE instead of PCI_DMA_TODEVICE.
>
> >
> > if (unlikely(pci_dma_mapping_error(fifo->pdev, dma_pointer)))
> > goto _exit2;
>
> I would also change this to dma_mapping_error() in one go.
>
> Just a random patch check.
Thanks Michał.
I'm sure I must have made the same mistakes in a whole bunch of patches
which have already been applied. I'll knock up a fixup patch.
Cheers,
Ian.
>
> Best Regards,
> Michał Mirosław
next prev parent reply other threads:[~2011-10-06 7:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 10:28 [PATCH 0/8] skb fragment API: convert network drivers (part IV) Ian Campbell
2011-10-05 10:28 ` [PATCH 1/8] vxge: convert to SKB paged frag API Ian Campbell
2011-10-05 21:03 ` Michał Mirosław
2011-10-05 21:32 ` David Miller
2011-10-06 7:05 ` Ian Campbell [this message]
2011-10-06 16:00 ` Ian Campbell
2011-10-06 20:00 ` David Miller
2011-10-06 20:45 ` Michał Mirosław
2011-10-06 21:08 ` Ian Campbell
2011-10-06 21:16 ` David Miller
2011-10-06 21:25 ` Ian Campbell
2011-10-06 21:56 ` David Miller
2011-10-07 5:29 ` Ian Campbell
2011-10-06 21:15 ` David Miller
2011-10-06 21:19 ` Ian Campbell
2011-10-06 21:28 ` Michał Mirosław
2011-10-05 10:28 ` [PATCH 2/8] xen: netback: " Ian Campbell
2011-10-05 10:28 ` [PATCH 3/8] xen: netfront: " Ian Campbell
2011-10-05 10:28 ` [PATCH 4/8] et131x: " Ian Campbell
2011-10-05 10:28 ` [PATCH 5/8] hv: netvsc: " Ian Campbell
2011-10-05 10:28 ` [PATCH 6/8] myri10ge: " Ian Campbell
2011-10-05 10:28 ` [PATCH 7/8] cxgb3: " Ian Campbell
2011-10-05 10:28 ` [PATCH 8/8] chelsio: " Ian Campbell
2011-10-05 19:17 ` [PATCH 0/8] skb fragment API: convert network drivers (part IV) Greg KH
2011-10-05 20:13 ` David Miller
2011-10-05 20:25 ` Greg KH
2011-10-05 20:49 ` David Miller
2011-10-05 21:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317884756.24742.13.camel@dagon.hellion.org.uk \
--to=ian.campbell@eu.citrix.com \
--cc=jdmason@kudzu.us \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).