From: Madalin Bucur <madalin.bucur@freescale.com>
To: <netdev@vger.kernel.org>, <davem@davemloft.net>
Cc: <afleming@freescale.com>, Madalin Bucur <madalin.bucur@freescale.com>
Subject: [PATCH 2/3] net/phy: avoid reaching an unsupported speed and duplex combination
Date: Thu, 6 Oct 2011 19:48:46 +0300 [thread overview]
Message-ID: <1317919726-25867-1-git-send-email-madalin.bucur@freescale.com> (raw)
- phy_force_reduction() may get the interface into a speed and duplex combination
that is not supported by the device;
- wait PHY_FORCE_TIMEOUT before each speed/duplex reduction in forced mode
Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
---
drivers/net/phy/phy.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 79268f6..31d6519 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -6,7 +6,7 @@
*
* Author: Andy Fleming
*
- * Copyright (c) 2004 Freescale Semiconductor, Inc.
+ * Copyright (c) 2004,2011 Freescale Semiconductor, Inc.
* Copyright (c) 2006, 2007 Maciej W. Rozycki
*
* This program is free software; you can redistribute it and/or modify it
@@ -479,6 +479,10 @@ static void phy_force_reduction(struct phy_device *phydev)
idx = phy_find_valid(idx, phydev->supported);
+ /* Avoid reaching an invalid speed and duplex combination */
+ if (!(settings[idx].setting & phydev->supported))
+ return;
+
phydev->speed = settings[idx].speed;
phydev->duplex = settings[idx].duplex;
@@ -869,6 +873,8 @@ void phy_state_machine(struct work_struct *work)
if (0 == phydev->link_timeout--) {
phy_force_reduction(phydev);
needs_aneg = 1;
+ phydev->link_timeout =
+ PHY_FORCE_TIMEOUT;
}
}
--
1.7.0.1
reply other threads:[~2011-10-06 16:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317919726-25867-1-git-send-email-madalin.bucur@freescale.com \
--to=madalin.bucur@freescale.com \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).