From: Ben Hutchings <bhutchings@solarflare.com>
To: Ashish Sharma <ashishsharma@google.com>
Cc: netdev@vger.kernel.org, jpa@google.com
Subject: Re: [PATCH] bridge: Have tx_bytes count headers like rx_bytes.
Date: Sat, 08 Oct 2011 01:14:46 +0100 [thread overview]
Message-ID: <1318032886.2771.149.camel@bwh-desktop> (raw)
In-Reply-To: <1318020461-14494-1-git-send-email-ashishsharma@google.com>
On Fri, 2011-10-07 at 13:47 -0700, Ashish Sharma wrote:
> Since rx_bytes accounting does not include Ethernet Headers in
> br_input.c, excluding ETH_HLEN on the transmit path for consistent
> measurement of packet length on both the Tx and Rx chains.
[...]
I think the TX path is correct in this regard, and the RX path should be
changed to include header length.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-10-08 0:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 20:47 [PATCH] bridge: Have tx_bytes count headers like rx_bytes Ashish Sharma
2011-10-08 0:14 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318032886.2771.149.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=ashishsharma@google.com \
--cc=jpa@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).