From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] gro: refetch inet6_protos[] after pulling ext headers
Date: Sun, 09 Oct 2011 11:33:51 +0200 [thread overview]
Message-ID: <1318152831.5276.30.camel@edumazet-laptop> (raw)
In-Reply-To: <4E915C9B.4000807@intel.com>
Le dimanche 09 octobre 2011 à 16:34 +0800, Yan, Zheng a écrit :
> ipv6_gro_receive() doesn't update the protocol ops after pulling
> the ext headers. It looks like a typo.
>
> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
> ---
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index 3b5669a..d27c797 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -875,6 +875,7 @@ static struct sk_buff **ipv6_gro_receive(struct sk_buff **head,
> skb_reset_transport_header(skb);
> __skb_push(skb, skb_gro_offset(skb));
>
> + ops = rcu_dereference(inet6_protos[proto]);
> if (!ops || !ops->gro_receive)
> goto out_unlock;
Good catch !
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2011-10-09 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 8:34 [PATCH] gro: refetch inet6_protos[] after pulling ext headers Yan, Zheng
2011-10-09 9:33 ` Eric Dumazet [this message]
2011-10-10 18:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318152831.5276.30.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox