From: Eric Dumazet <eric.dumazet@gmail.com>
To: MuraliRaja Muniraju <muralira@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] net-netlink: Add a new attribute to expose TOS values via netlink
Date: Wed, 12 Oct 2011 06:31:09 +0200 [thread overview]
Message-ID: <1318393869.3686.26.camel@edumazet-laptop> (raw)
In-Reply-To: <CAP3iWTQXHwzw-qUYVfT--uNv4pNZnu0ROJnF7B1VLeZBbrfdqw@mail.gmail.com>
Le mardi 11 octobre 2011 à 21:16 -0700, MuraliRaja Muniraju a écrit :
> Eric,
> I think it would be useful to expose the values this way.
> I shall make the changes to add TCLASS for ipv6 in the description.
>
> Regarding the TIME_WAIT state, I think it would be better of not
> exposing the values because there would hardly be anything to transmit
> during this time.
>
My remark had nothing to do with your patch actually :
We dont store TOS/TCLASS on TIME_WAIT sockets, so you cannot report
value in inet_diag.
But we do send packets on behalf of TIME_WAIT sockets ;)
Think about ACK messages. They probably are sent with a 0 TOS/TCLASS
field... I am not sure its a problem or not.
next prev parent reply other threads:[~2011-10-12 4:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111010145206.6f7e9ee2@nehalam.linuxnetplumber.net>
2011-10-12 1:28 ` [PATCH v3] net-netlink: Add a new attribute to expose TOS values via netlink Muraliraja Muniraju
2011-10-12 2:48 ` Eric Dumazet
2011-10-12 4:16 ` MuraliRaja Muniraju
2011-10-12 4:31 ` Eric Dumazet [this message]
2011-10-12 19:00 ` MuraliRaja Muniraju
2011-10-21 10:29 ` [PATCH net-next] ipv4: tcp: fix TOS value in ACK messages sent from TIME_WAIT Eric Dumazet
2011-10-24 7:06 ` David Miller
2011-10-12 15:52 ` [PATCH v3] net-netlink: Add a new attribute to expose TOS values via netlink Stephen Hemminger
2011-10-12 19:00 ` [PATCH v4] " Muraliraja Muniraju
2011-10-12 19:08 ` Stephen Hemminger
2011-10-12 19:15 ` Eric Dumazet
2011-10-12 23:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318393869.3686.26.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=muralira@google.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox