From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH net-next] net: more accurate skb truesize
Date: Thu, 13 Oct 2011 18:13:10 +0100 [thread overview]
Message-ID: <1318525990.2745.33.camel@bwh-desktop> (raw)
In-Reply-To: <1318525877.2393.41.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Thu, 2011-10-13 at 19:11 +0200, Eric Dumazet wrote:
> Le jeudi 13 octobre 2011 à 17:32 +0100, Ben Hutchings a écrit :
>
> > Fair enough, but please add a comment explaining this.
> >
>
>
> What about :
>
> /* We do our best to align skb_shared_info on a separate cache
> * line. It usually works because kmalloc(X > CACHE_BYTES) gives
> * aligned memory blocks, unless SLUB/SLAB debug is enabled.
> */
> size += SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
Yes, that seems like a good explanation.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-10-13 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 15:26 [PATCH net-next] net: more accurate skb truesize Eric Dumazet
2011-10-13 16:05 ` Ben Hutchings
2011-10-13 16:24 ` Eric Dumazet
2011-10-13 16:32 ` Ben Hutchings
2011-10-13 17:11 ` Eric Dumazet
2011-10-13 17:13 ` Ben Hutchings [this message]
2011-10-13 17:28 ` Eric Dumazet
2011-10-13 20:05 ` David Miller
2011-10-13 20:33 ` Andi Kleen
2011-10-13 20:51 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318525990.2745.33.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=ak@linux.intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox