From: Eric Dumazet <eric.dumazet@gmail.com>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [Bug] skb truesize does not update properly in many place
Date: Fri, 14 Oct 2011 07:48:33 +0200 [thread overview]
Message-ID: <1318571313.2533.77.camel@edumazet-laptop> (raw)
In-Reply-To: <1318570381-4731-1-git-send-email-roy.qing.li@gmail.com>
Le vendredi 14 octobre 2011 à 13:33 +0800, roy.qing.li@gmail.com a
écrit :
> Hi Eric Dumazet:
>
> I see you are correcting the wrong skb truesize, I found the
> same problem exists in many forms and many places, like:
>
> After calling skb_fill_page_desc(), what should be updated
> to truesize.
>
> pskb_expand_head(), __pskb_pull_tail()... do not update the
> truesize.
All this is scheduled, but any help is appreciated.
I gave the general idea and patched some drivers, I hope other dev will
follow me in this work.
I am now focusing in the TCP pruning effect, that we can see with WIFI
drivers (and also with drivers using a full PAGE to store a 1500 byte
tcp frame), when a single packet loss is happening on a session with
large RTT.
All this truesize saga started because I was shocked by following
"netstat -s" extract on my laptop after few minutes of Internet stuff.
848 packets collapsed in receive queue due to low socket buffer
next prev parent reply other threads:[~2011-10-14 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 5:33 [Bug] skb truesize does not update properly in many place roy.qing.li
2011-10-14 5:48 ` Eric Dumazet [this message]
2011-10-14 5:51 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318571313.2533.77.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox