From: Matthew Daley <mattjd@gmail.com>
To: netdev@vger.kernel.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Andrew Hendry <andrew.hendry@gmail.com>
Subject: x25: Fix multiple buffer overruns/overreads
Date: Sat, 15 Oct 2011 00:45:02 -0400 [thread overview]
Message-ID: <1318653905-13716-1-git-send-email-mattjd@gmail.com> (raw)
This patchset fixes several buffer overruns/overreads in the X.25
packet layer. The first patch fixes a particularly nasty remote-triggerable
buffer overflow, while the rest fix skb overreads on undersized/fragmented
skbs.
Matthew Daley (3):
x25: Validate incoming call user data lengths
x25: Handle undersized/fragmented skbs
x25: Prevent skb overreads when checking call user data
net/x25/af_x25.c | 40 ++++++++++++++++++++++++++++++++--------
net/x25/x25_dev.c | 6 ++++++
net/x25/x25_facilities.c | 10 ++++++----
net/x25/x25_in.c | 43 ++++++++++++++++++++++++++++++++++++++-----
net/x25/x25_link.c | 3 +++
net/x25/x25_subr.c | 14 +++++++++++++-
6 files changed, 98 insertions(+), 18 deletions(-)
next reply other threads:[~2011-10-15 4:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 4:45 Matthew Daley [this message]
2011-10-15 4:45 ` [PATCH 1/3] x25: Validate incoming call user data lengths Matthew Daley
2011-10-15 4:45 ` [PATCH 2/3] x25: Handle undersized/fragmented skbs Matthew Daley
2011-10-17 10:28 ` Andrew Hendry
2011-10-15 4:45 ` [PATCH 3/3] x25: Prevent skb overreads when checking call user data Matthew Daley
2011-10-17 10:28 ` Andrew Hendry
2011-10-17 23:32 ` x25: Fix multiple buffer overruns/overreads David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318653905-13716-1-git-send-email-mattjd@gmail.com \
--to=mattjd@gmail.com \
--cc=andrew.hendry@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).