From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Greg Rose <gregory.v.rose@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Christian Benvenuti <benve@cisco.com>,
Sathya Perla <sathya.perla@emulex.com>,
Dimitris Michailidis <dm@chelsio.com>,
Jon Mason <jdmason@kudzu.us>,
James Smart <james.smart@emulex.com>
Subject: Re: [net-next 2/6 v2] igb: Check if subordinate VFs are assigned to virtual machines
Date: Mon, 17 Oct 2011 08:53:58 -0700 [thread overview]
Message-ID: <1318866838.5407.3.camel@Joe-Laptop> (raw)
In-Reply-To: <1318854062-3628-3-git-send-email-jeffrey.t.kirsher@intel.com>
On Mon, 2011-10-17 at 05:20 -0700, Jeff Kirsher wrote:
> From: Greg Rose <gregory.v.rose@intel.com>
Trivia:
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
[]
> + if (old_vfs) {
> + dev_info(&pdev->dev, "%d pre-allocated VFs found - override "
> + "max_vfs setting of %d\n", old_vfs, max_vfs);
[]
> + dev_err(&pdev->dev, "Unable to allocate memory for VF "
> + "Data Storage\n");
The dev_err line isn't really necessary.
There is a generic allocation failure dump_stack.
Also, please don't split formats into multiple lines.
next prev parent reply other threads:[~2011-10-17 15:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 12:20 [net-next 0/6 v2][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-10-17 12:20 ` [net-next 1/6] igbvf: Fix trunk vlan Jeff Kirsher
2011-10-17 12:20 ` [net-next 2/6 v2] igb: Check if subordinate VFs are assigned to virtual machines Jeff Kirsher
2011-10-17 15:53 ` Joe Perches [this message]
2011-10-17 12:20 ` [net-next 3/6] ixgbe: fix endianess when writing driver version to firmware Jeff Kirsher
2011-10-17 12:21 ` [net-next 4/6] ixgbe: allow eeprom writes via ethtool Jeff Kirsher
2011-10-17 12:21 ` [net-next 5/6] ixgbe: add hardware timestamping support Jeff Kirsher
2011-10-17 16:44 ` Richard Cochran
2011-10-19 17:04 ` Jacob Keller
2011-10-20 14:56 ` Richard Cochran
2011-10-20 19:57 ` Keller, Jacob E
2011-10-17 12:21 ` [net-next 6/6] ixgbe: change the eeprom version reported by ethtool Jeff Kirsher
2011-10-17 15:57 ` Joe Perches
2011-10-17 17:16 ` Ben Hutchings
2011-10-17 18:02 ` Tantilov, Emil S
2011-10-17 22:49 ` [net-next 0/6 v2][pull request] Intel Wired LAN Driver Updates David Miller
2011-10-17 22:53 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318866838.5407.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=james.smart@emulex.com \
--cc=jdmason@kudzu.us \
--cc=jeffrey.t.kirsher@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox