Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] route:ip_rt_frag_needed always return unzero
Date: Wed, 19 Oct 2011 05:57:00 +0200	[thread overview]
Message-ID: <1318996620.19139.9.camel@edumazet-laptop> (raw)
In-Reply-To: <4E9E36DC.4050304@cn.fujitsu.com>

Le mercredi 19 octobre 2011 à 10:33 +0800, Gao feng a écrit :

> And move atomic_inc(&__rt_peer_genid) just like func ip_rt_update_pmtu?
> 
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 6cde0fa..3e1aa5c 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1568,11 +1568,12 @@ unsigned short ip_rt_frag_needed(struct net *net, const
>                         est_mtu = mtu;
>                         peer->pmtu_learned = mtu;
>                         peer->pmtu_expires = pmtu_expires;
> +
> +                       atomic_inc(&__rt_peer_genid);
>                 }
> 
>                 inet_putpeer(peer);
> 
> -               atomic_inc(&__rt_peer_genid);
>         }
>         return est_mtu;
>  }
> 

This one is fine, please provide a changelog and official submission.

Thanks

  reply	other threads:[~2011-10-19  3:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18  7:04 [PATCH] route:ip_rt_frag_needed always return unzero Gao feng
2011-10-18  9:23 ` Eric Dumazet
2011-10-19  1:34   ` Gao feng
2011-10-19  2:33     ` Gao feng
2011-10-19  3:57       ` Eric Dumazet [this message]
2011-10-19  3:49     ` Eric Dumazet
2011-10-19  5:20       ` Gao feng
2011-10-19  5:47         ` Eric Dumazet
2011-10-19  6:36           ` Gao feng
2011-10-19  7:26         ` Steffen Klassert
2011-10-19  8:07           ` Gao feng
2011-10-19  8:38             ` Steffen Klassert
2011-10-19  8:59               ` Gao feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318996620.19139.9.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gaofeng@cn.fujitsu.com \
    --cc=jmorris@namei.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox