From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH 0/3] net: time stamping fixes Date: Wed, 19 Oct 2011 15:44:16 +0200 Message-ID: <1319031856.8416.19.camel@edumazet-laptop> References: <56185ca8a7dc0223031ca0f0996302cac1b497eb.1318444117.git.richard.cochran@omicron.at> <20111019.001610.312990203017422173.davem@davemloft.net> <1319001336.4424.8.camel@jlt3.sipsolutions.net> <20111019115012.GA7206@netboy.at.omicron.at> <1319027881.3103.27.camel@edumazet-laptop> (sfid-20111019_143837_360206_014A6AA4) <1319029101.4424.36.camel@jlt3.sipsolutions.net> <1319029794.4424.37.camel@jlt3.sipsolutions.net> <1319030740.8416.14.camel@edumazet-laptop> (sfid-20111019_152616_037809_8B36A3CC) <1319031348.1286.4.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Richard Cochran , David Miller , netdev@vger.kernel.org To: Johannes Berg Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:59087 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890Ab1JSNoX (ORCPT ); Wed, 19 Oct 2011 09:44:23 -0400 Received: by wwe6 with SMTP id 6so2549756wwe.1 for ; Wed, 19 Oct 2011 06:44:22 -0700 (PDT) In-Reply-To: <1319031348.1286.4.camel@jlt3.sipsolutions.net> Sender: netdev-owner@vger.kernel.org List-ID: Le mercredi 19 octobre 2011 =C3=A0 15:35 +0200, Johannes Berg a =C3=A9c= rit : > Even with that fixed I'm not really convinced of it all -- need to > really really really make sure that no skb->sk that was owned by a TX > skb is ever passed to sock_hold(). Can we really guarantee that? Either we can guarantee that, or kernel is a piece of crap, all bets ar= e off. Yes, we need to make an audit, since we assumed sock_hold() was the right thing to do in all contexts.