From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [patch net-next]alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver Date: Wed, 19 Oct 2011 15:59:18 -0700 Message-ID: <1319065158.27047.6.camel@Joe-Laptop> References: <1319009213-20627-1-git-send-email-cloud.ren@atheros.com> <20111019222140.GA9937@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: cloud.ren@atheros.com, davem@davemloft.net, Luis.Rodriguez@atheros.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Francois Romieu Return-path: In-Reply-To: <20111019222140.GA9937@electric-eye.fr.zoreil.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2011-10-20 at 00:21 +0200, Francois Romieu wrote: > cloud.ren@atheros.com : > > diff --git a/drivers/net/ethernet/atheros/alx/alc_cb.c b/drivers/net/ethernet/atheros/alx/alc_cb.c > [...] A bunch of good style comments. > > + hw->autoneg_advertised = (ALX_LINK_SPEED_1GB_FULL | > > + ALX_LINK_SPEED_10_HALF | > > + ALX_LINK_SPEED_10_FULL | > > + ALX_LINK_SPEED_100_HALF | > > + ALX_LINK_SPEED_100_FULL); > Parenthesis abuse. Maybe. I use parenthesis too, but not the trailing | alignment. emacs does leading alignment nicely when you use an open paren.