From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Moffett Subject: [RFC PATCH 08/17] drivers/net/bfin_mac: Don't unnecessarily reset the PHY Date: Thu, 20 Oct 2011 17:00:15 -0400 Message-ID: <1319144425-15547-9-git-send-email-Kyle.D.Moffett@boeing.com> References: <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> Cc: Kyle Moffett , "David S. Miller" , Mike Frysinger , Sonic Zhang , Tobias Klauser , uclinux-dist-devel@blackfin.uclinux.org To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: In-Reply-To: <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org The PHY is already reset during driver probing, and this manual reset afterwards will wipe out board-specific PHY fixups and driver-specific phy->drv->config_init() register tweaks. Signed-off-by: Kyle Moffett --- drivers/net/bfin_mac.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index 6c019e1..1427ec3 100644 --- a/drivers/net/bfin_mac.c +++ b/drivers/net/bfin_mac.c @@ -1402,7 +1402,6 @@ static int bfin_mac_open(struct net_device *dev) return ret; phy_start(lp->phydev); - phy_write(lp->phydev, MII_BMCR, BMCR_RESET); setup_system_regs(dev); setup_mac_addr(dev->dev_addr); -- 1.7.2.5