-next: NET_VENDOR_8390 dependencies

-next: NET_VENDOR_8390 dependencies

[Geert Uytterhoeven]

drivers/net/ethernet/8390/Kconfig:

config NET_VENDOR_8390
        bool "National Semi-conductor 8390 devices"
        default y
        depends on NET_VENDOR_NATSEMI && (AMIGA_PCMCIA || PCI || SUPERH || \
                   ISA || MCA || EISA || MAC || M32R || MACH_TX49XX || \
                   MCA_LEGACY || H8300 || ARM || MIPS || ZORRO || PCMCIA || \
                   EXPERIMENTAL)
        ---help---
          If you have a network (Ethernet) card belonging to this class, say Y
          and read the Ethernet-HOWTO, available from
          <http://www.tldp.org/docs.html#howto>.

          Note that the answer to this question doesn't directly affect the
          kernel: saying N will just cause the configurator to skip all
          the questions about Western Digital cards. If you say Y, you will be
          asked for your specific card in the following questions.

So NET_VENDOR_8390 depends on NET_VENDOR_NATSEMI.

drivers/net/ethernet/natsemi/Kconfig:

config NET_VENDOR_NATSEMI
        bool "National Semi-conductor devices"
        default y
        depends on MCA || MAC || MACH_JAZZ || PCI || XTENSA_PLATFORM_XT2000
        ---help---
          If you have a network (Ethernet) card belonging to this class, say Y
          and read the Ethernet-HOWTO, available from
          <http://www.tldp.org/docs.html#howto>.

          Note that the answer to this question doesn't directly affect the
          kernel: saying N will just cause the configurator to skip all
          the questions about National Semi-conductor devices. If you say Y,
          you will be asked for your specific card in the following questions.

But NET_VENDOR_NATSEMI will never be true for several of the other
dependencies of NET_VENDOR_8390 (e.g. AMIGA_PCMCIA, EISA, H8300, ARM,
ZORRO, PCMCIA)?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: -next: NET_VENDOR_8390 dependencies

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 2060 bytes --]

On Sun, 2011-10-23 at 14:21 -0700, Geert Uytterhoeven wrote:
> drivers/net/ethernet/8390/Kconfig:
> 
> config NET_VENDOR_8390
>         bool "National Semi-conductor 8390 devices"
>         default y
>         depends on NET_VENDOR_NATSEMI && (AMIGA_PCMCIA || PCI || SUPERH || \
>                    ISA || MCA || EISA || MAC || M32R || MACH_TX49XX || \
>                    MCA_LEGACY || H8300 || ARM || MIPS || ZORRO || PCMCIA || \
>                    EXPERIMENTAL)
>         ---help---
>           If you have a network (Ethernet) card belonging to this class, say Y
>           and read the Ethernet-HOWTO, available from
>           <http://www.tldp.org/docs.html#howto>.
> 
>           Note that the answer to this question doesn't directly affect the
>           kernel: saying N will just cause the configurator to skip all
>           the questions about Western Digital cards. If you say Y, you will be
>           asked for your specific card in the following questions.
> 
> So NET_VENDOR_8390 depends on NET_VENDOR_NATSEMI.
> 
> drivers/net/ethernet/natsemi/Kconfig:
> 
> config NET_VENDOR_NATSEMI
>         bool "National Semi-conductor devices"
>         default y
>         depends on MCA || MAC || MACH_JAZZ || PCI || XTENSA_PLATFORM_XT2000
>         ---help---
>           If you have a network (Ethernet) card belonging to this class, say Y
>           and read the Ethernet-HOWTO, available from
>           <http://www.tldp.org/docs.html#howto>.
> 
>           Note that the answer to this question doesn't directly affect the
>           kernel: saying N will just cause the configurator to skip all
>           the questions about National Semi-conductor devices. If you say Y,
>           you will be asked for your specific card in the following questions.
> 
> But NET_VENDOR_NATSEMI will never be true for several of the other
> dependencies of NET_VENDOR_8390 (e.g. AMIGA_PCMCIA, EISA, H8300, ARM,
> ZORRO, PCMCIA)?
> 

You are correct, I will put together a patch to fix that.  Thanks!

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: -next: NET_VENDOR_8390 dependencies

[Geert Uytterhoeven]

On Sun, Oct 23, 2011 at 23:21, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> drivers/net/ethernet/8390/Kconfig:
>
> config NET_VENDOR_8390
>        depends on NET_VENDOR_NATSEMI && (AMIGA_PCMCIA || PCI || SUPERH || \
>                   ISA || MCA || EISA || MAC || M32R || MACH_TX49XX || \
>                   MCA_LEGACY || H8300 || ARM || MIPS || ZORRO || PCMCIA || \
>                   EXPERIMENTAL)

> So NET_VENDOR_8390 depends on NET_VENDOR_NATSEMI.

> config NET_VENDOR_NATSEMI
>        depends on MCA || MAC || MACH_JAZZ || PCI || XTENSA_PLATFORM_XT2000

> But NET_VENDOR_NATSEMI will never be true for several of the other
> dependencies of NET_VENDOR_8390 (e.g. AMIGA_PCMCIA, EISA, H8300, ARM,
> ZORRO, PCMCIA)?

There's a similar issue with:

config NET_VENDOR_I825XX
        depends on NET_VENDOR_INTEL && (ISA || ISA_DMA_API || ARM || \
                   ARCH_ACORN || MCA || MCA_LEGACY || SNI_RM || SUN3 || \
                   GSC || BVME6000 || MVME16x || EXPERIMENTAL)

But:

config NET_VENDOR_INTEL
        depends on PCI || PCI_MSI

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: -next: NET_VENDOR_8390 dependencies

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

On Fri, 2011-10-28 at 13:35 -0700, Geert Uytterhoeven wrote:
> On Sun, Oct 23, 2011 at 23:21, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > drivers/net/ethernet/8390/Kconfig:
> >
> > config NET_VENDOR_8390
> >        depends on NET_VENDOR_NATSEMI && (AMIGA_PCMCIA || PCI ||
> SUPERH || \
> >                   ISA || MCA || EISA || MAC || M32R || MACH_TX49XX
> || \
> >                   MCA_LEGACY || H8300 || ARM || MIPS || ZORRO ||
> PCMCIA || \
> >                   EXPERIMENTAL)
> 
> > So NET_VENDOR_8390 depends on NET_VENDOR_NATSEMI.
> 
> > config NET_VENDOR_NATSEMI
> >        depends on MCA || MAC || MACH_JAZZ || PCI ||
> XTENSA_PLATFORM_XT2000
> 
> > But NET_VENDOR_NATSEMI will never be true for several of the other
> > dependencies of NET_VENDOR_8390 (e.g. AMIGA_PCMCIA, EISA, H8300,
> ARM,
> > ZORRO, PCMCIA)?
> 
> There's a similar issue with:
> 
> config NET_VENDOR_I825XX
>         depends on NET_VENDOR_INTEL && (ISA || ISA_DMA_API || ARM || \
>                    ARCH_ACORN || MCA || MCA_LEGACY || SNI_RM || SUN3
> || \
>                    GSC || BVME6000 || MVME16x || EXPERIMENTAL)
> 
> But:
> 
> config NET_VENDOR_INTEL
>         depends on PCI || PCI_MSI
> 
> Gr{oetje,eeting}s,
> 
>                         Geert 

Thanks Geert, I will put together a patch to resolve both issues.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]