From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH v4 0/9] Cleanup and extension of netdev features
Date: Tue, 25 Oct 2011 05:35:54 +0200 [thread overview]
Message-ID: <1319513754.3834.4.camel@edumazet-laptop> (raw)
In-Reply-To: <cover.1319495301.git.mirq-linux@rere.qmqm.pl>
Le mardi 25 octobre 2011 à 02:36 +0200, Michał Mirosław a écrit :
> Commit fd38f734 (igbvf: convert to ndo_fix_features) removed last use
> of old ethtool ops for controlling netdevice's features. This series
> finishes the cleanup and extends feature pool to 64 bits.
>
> Also, there's additional patch that removes NETIF_F_NO_CSUM as it is
> now, and has been for some time, equivalent to NETIF_F_HW_CSUM.
>
> To see the new features in action, you need ethtool patched with:
>
> http://patchwork.ozlabs.org/patch/96374/
>
> Not much has changed in those patches compared to last version I posted
> in June.
Hi Michal
This reminds me current net-next is busted for bond/vlan, I dont know
why.
$ cat /proc/net/bonding/bond0
Ethernet Channel Bonding Driver: v3.7.1 (April 27, 2011)
Bonding Mode: fault-tolerance (active-backup)
Primary Slave: None
Currently Active Slave: eth2
MII Status: up
MII Polling Interval (ms): 100
Up Delay (ms): 0
Down Delay (ms): 0
Slave Interface: eth1
MII Status: up
Speed: 1000 Mbps
Duplex: full
Link Failure Count: 1
Permanent HW addr: 00:1e:0b:ec:d3:d2
Slave queue ID: 0
Slave Interface: eth2
MII Status: up
Speed: 1000 Mbps
Duplex: full
Link Failure Count: 0
Permanent HW addr: 00:1e:0b:92:78:50
Slave queue ID: 0
$ ethtool -k eth1
Offload parameters for eth1:
rx-checksumming: on
tx-checksumming: on
scatter-gather: on
tcp-segmentation-offload: on
udp-fragmentation-offload: off
generic-segmentation-offload: on
generic-receive-offload: on
large-receive-offload: off
rx-vlan-offload: on
tx-vlan-offload: on
ntuple-filters: off
receive-hashing: on
$ ethtool -k eth2
Offload parameters for eth2:
rx-checksumming: on
tx-checksumming: on
scatter-gather: on
tcp-segmentation-offload: on
udp-fragmentation-offload: off
generic-segmentation-offload: on
generic-receive-offload: on
large-receive-offload: off
rx-vlan-offload: on
tx-vlan-offload: on
ntuple-filters: off
receive-hashing: off
$ ethtool -k bond0
Offload parameters for bond0:
rx-checksumming: on
tx-checksumming: on
scatter-gather: on
tcp-segmentation-offload: on
udp-fragmentation-offload: off
generic-segmentation-offload: on
generic-receive-offload: on
large-receive-offload: off
rx-vlan-offload: on
tx-vlan-offload: on
ntuple-filters: off
receive-hashing: off
$ ip link show dev vlan.103
7: vlan.103@bond0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc
pfifo_fast state UP qlen 100
link/ether 00:1e:0b:ec:d3:d2 brd ff:ff:ff:ff:ff:ff
But :
$ ethtool -k vlan.103
Offload parameters for vlan.103:
rx-checksumming: off
tx-checksumming: off
scatter-gather: off
tcp-segmentation-offload: off
udp-fragmentation-offload: off
generic-segmentation-offload: off
generic-receive-offload: on
large-receive-offload: off
rx-vlan-offload: off
tx-vlan-offload: off
ntuple-filters: off
receive-hashing: off
So basically all features but GRO are off.
next prev parent reply other threads:[~2011-10-25 3:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 0:36 [PATCH v4 0/9] Cleanup and extension of netdev features Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 3/9] net: split netdev features to separate header Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 4/9] net: introduce and use netdev_features_t for device features sets Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 5/9] net: Define enum for net device features Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 9/9] net: remove NETIF_F_NO_CSUM feature bit Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 6/9] net: ethtool: use C99 array initialization for feature-names table Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 1/9] net: remove legacy ethtool ops Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 8/9] net: extend netdev_features_t to 64 bits Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 7/9] ethtool: prepare for larger netdev_features_t type Michał Mirosław
2011-10-25 0:36 ` [PATCH v4 2/9] net: ethtool: break association of ETH_FLAG_* with NETIF_F_* Michał Mirosław
2011-10-25 3:35 ` Eric Dumazet [this message]
2011-10-25 3:44 ` [PATCH v4 0/9] Cleanup and extension of netdev features Eric Dumazet
2011-10-28 21:47 ` Michał Mirosław
2011-11-04 2:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319513754.3834.4.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox