Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]

On Fri, 2011-10-21 at 11:08 +0200, Marc Haber wrote:
> On Fri, Oct 21, 2011 at 11:00:46AM +0200, Marc Haber wrote:
> > On Thu, Oct 20, 2011 at 05:28:34AM +0100, Ben Hutchings wrote:
> > > I don't see any changes that would obviously change the way this device
> > > is reconfigured during a down/up cycle.  There were some changes to
> > > power management that should just let the PCI core do some work that the
> > > driver used to, but it's possible that the result isn't quite the same.
> > > I built a module with those reverted; source and binary attached.  Could
> > > you test that?  I checked that d-i does include an insmod command.
> > 
> > The squeeze 6.0.3 installer with the shipped tg3.ko replaced with
> > yours boots and networks just fine without any workaround and without
> > manual interaction.
> 
> I was a bit fast on that. The interface now fails right in the middle
> of installation and needs the modprobe -r, modprobe stunt to network
> again.

Matt, Michael,

The tg3 driver has regressed for the 5714S since Linux 2.6.32.  Marc
Haber found this in the backported version included in our stable
update, but also confirmed it in Linux 3.0.

Bringing the interface down and then up again (which the installer does
for some reason) can leave it unable to pass traffic (possibly after
working for a few packets) until the module is reloaded.

I asked Marc to check whether reverting the power management changes
(071697e2bcd8dff2af4d6fdd6525c2324f89553b,
d237d9ecf06a00f0ebca657958cf2a1e92940796) made a difference, but it
doesn't seem to.

There is more information in the bug log at
<http://bugs.debian.org/645308>.

Ben.

-- 
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Matt Carlson]

On Fri, Oct 21, 2011 at 05:19:39AM -0700, Ben Hutchings wrote:
> On Fri, 2011-10-21 at 11:08 +0200, Marc Haber wrote:
> > On Fri, Oct 21, 2011 at 11:00:46AM +0200, Marc Haber wrote:
> > > On Thu, Oct 20, 2011 at 05:28:34AM +0100, Ben Hutchings wrote:
> > > > I don't see any changes that would obviously change the way this device
> > > > is reconfigured during a down/up cycle.  There were some changes to
> > > > power management that should just let the PCI core do some work that the
> > > > driver used to, but it's possible that the result isn't quite the same.
> > > > I built a module with those reverted; source and binary attached.  Could
> > > > you test that?  I checked that d-i does include an insmod command.
> > > 
> > > The squeeze 6.0.3 installer with the shipped tg3.ko replaced with
> > > yours boots and networks just fine without any workaround and without
> > > manual interaction.
> > 
> > I was a bit fast on that. The interface now fails right in the middle
> > of installation and needs the modprobe -r, modprobe stunt to network
> > again.
> 
> Matt, Michael,
> 
> The tg3 driver has regressed for the 5714S since Linux 2.6.32.  Marc
> Haber found this in the backported version included in our stable
> update, but also confirmed it in Linux 3.0.
> 
> Bringing the interface down and then up again (which the installer does
> for some reason) can leave it unable to pass traffic (possibly after
> working for a few packets) until the module is reloaded.
> 
> I asked Marc to check whether reverting the power management changes
> (071697e2bcd8dff2af4d6fdd6525c2324f89553b,
> d237d9ecf06a00f0ebca657958cf2a1e92940796) made a difference, but it
> doesn't seem to.
> 
> There is more information in the bug log at
> <http://bugs.debian.org/645308>.

Where can I get the sources for this driver?  Commit
9e975cc291d80d5e4562d6bed15ec171e896d69b, entitled
"tg3: Fix io failures after chip reset" has been a common source of
problems.

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2564 bytes --]

On Mon, 2011-10-24 at 14:24 -0700, Matt Carlson wrote:
> On Fri, Oct 21, 2011 at 05:19:39AM -0700, Ben Hutchings wrote:
> > On Fri, 2011-10-21 at 11:08 +0200, Marc Haber wrote:
> > > On Fri, Oct 21, 2011 at 11:00:46AM +0200, Marc Haber wrote:
> > > > On Thu, Oct 20, 2011 at 05:28:34AM +0100, Ben Hutchings wrote:
> > > > > I don't see any changes that would obviously change the way this device
> > > > > is reconfigured during a down/up cycle.  There were some changes to
> > > > > power management that should just let the PCI core do some work that the
> > > > > driver used to, but it's possible that the result isn't quite the same.
> > > > > I built a module with those reverted; source and binary attached.  Could
> > > > > you test that?  I checked that d-i does include an insmod command.
> > > > 
> > > > The squeeze 6.0.3 installer with the shipped tg3.ko replaced with
> > > > yours boots and networks just fine without any workaround and without
> > > > manual interaction.
> > > 
> > > I was a bit fast on that. The interface now fails right in the middle
> > > of installation and needs the modprobe -r, modprobe stunt to network
> > > again.
> > 
> > Matt, Michael,
> > 
> > The tg3 driver has regressed for the 5714S since Linux 2.6.32.  Marc
> > Haber found this in the backported version included in our stable
> > update, but also confirmed it in Linux 3.0.
> > 
> > Bringing the interface down and then up again (which the installer does
> > for some reason) can leave it unable to pass traffic (possibly after
> > working for a few packets) until the module is reloaded.
> > 
> > I asked Marc to check whether reverting the power management changes
> > (071697e2bcd8dff2af4d6fdd6525c2324f89553b,
> > d237d9ecf06a00f0ebca657958cf2a1e92940796) made a difference, but it
> > doesn't seem to.
> > 
> > There is more information in the bug log at
> > <http://bugs.debian.org/645308>.
> 
> Where can I get the sources for this driver?  Commit
> 9e975cc291d80d5e4562d6bed15ec171e896d69b, entitled
> "tg3: Fix io failures after chip reset" has been a common source of
> problems.

Our current package has Linux 3.0.6 which includes the backport of that
change.  However, it is *not* included in my backport to 2.6.32 so it
doesn't explain the original report.

The backported version can be found in:

git://anonscm.debian.org/kernel/linux-2.6.git squeeze

Ben.

-- 
Ben Hutchings
DNRC Motto:  I can please only one person per day.
Today is not your day.  Tomorrow isn't looking good either.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Matt Carlson]

On Mon, Oct 24, 2011 at 04:47:54PM -0700, Ben Hutchings wrote:
> On Mon, 2011-10-24 at 14:24 -0700, Matt Carlson wrote:
> > On Fri, Oct 21, 2011 at 05:19:39AM -0700, Ben Hutchings wrote:
> > > On Fri, 2011-10-21 at 11:08 +0200, Marc Haber wrote:
> > > > On Fri, Oct 21, 2011 at 11:00:46AM +0200, Marc Haber wrote:
> > > > > On Thu, Oct 20, 2011 at 05:28:34AM +0100, Ben Hutchings wrote:
> > > > > > I don't see any changes that would obviously change the way this device
> > > > > > is reconfigured during a down/up cycle.  There were some changes to
> > > > > > power management that should just let the PCI core do some work that the
> > > > > > driver used to, but it's possible that the result isn't quite the same.
> > > > > > I built a module with those reverted; source and binary attached.  Could
> > > > > > you test that?  I checked that d-i does include an insmod command.
> > > > > 
> > > > > The squeeze 6.0.3 installer with the shipped tg3.ko replaced with
> > > > > yours boots and networks just fine without any workaround and without
> > > > > manual interaction.
> > > > 
> > > > I was a bit fast on that. The interface now fails right in the middle
> > > > of installation and needs the modprobe -r, modprobe stunt to network
> > > > again.
> > > 
> > > Matt, Michael,
> > > 
> > > The tg3 driver has regressed for the 5714S since Linux 2.6.32.  Marc
> > > Haber found this in the backported version included in our stable
> > > update, but also confirmed it in Linux 3.0.
> > > 
> > > Bringing the interface down and then up again (which the installer does
> > > for some reason) can leave it unable to pass traffic (possibly after
> > > working for a few packets) until the module is reloaded.
> > > 
> > > I asked Marc to check whether reverting the power management changes
> > > (071697e2bcd8dff2af4d6fdd6525c2324f89553b,
> > > d237d9ecf06a00f0ebca657958cf2a1e92940796) made a difference, but it
> > > doesn't seem to.
> > > 
> > > There is more information in the bug log at
> > > <http://bugs.debian.org/645308>.
> > 
> > Where can I get the sources for this driver?  Commit
> > 9e975cc291d80d5e4562d6bed15ec171e896d69b, entitled
> > "tg3: Fix io failures after chip reset" has been a common source of
> > problems.
> 
> Our current package has Linux 3.0.6 which includes the backport of that
> change.  However, it is *not* included in my backport to 2.6.32 so it
> doesn't explain the original report.
> 
> The backported version can be found in:
> 
> git://anonscm.debian.org/kernel/linux-2.6.git squeeze

The kernel version of that repository is 3.0.0-rc1.  Am I looking in the
right place?

But you're right.  The version of the driver in that repository does not
have the change.

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 3089 bytes --]

On Tue, 2011-10-25 at 17:20 -0700, Matt Carlson wrote:
> On Mon, Oct 24, 2011 at 04:47:54PM -0700, Ben Hutchings wrote:
> > On Mon, 2011-10-24 at 14:24 -0700, Matt Carlson wrote:
> > > On Fri, Oct 21, 2011 at 05:19:39AM -0700, Ben Hutchings wrote:
> > > > On Fri, 2011-10-21 at 11:08 +0200, Marc Haber wrote:
> > > > > On Fri, Oct 21, 2011 at 11:00:46AM +0200, Marc Haber wrote:
> > > > > > On Thu, Oct 20, 2011 at 05:28:34AM +0100, Ben Hutchings wrote:
> > > > > > > I don't see any changes that would obviously change the way this device
> > > > > > > is reconfigured during a down/up cycle.  There were some changes to
> > > > > > > power management that should just let the PCI core do some work that the
> > > > > > > driver used to, but it's possible that the result isn't quite the same.
> > > > > > > I built a module with those reverted; source and binary attached.  Could
> > > > > > > you test that?  I checked that d-i does include an insmod command.
> > > > > > 
> > > > > > The squeeze 6.0.3 installer with the shipped tg3.ko replaced with
> > > > > > yours boots and networks just fine without any workaround and without
> > > > > > manual interaction.
> > > > > 
> > > > > I was a bit fast on that. The interface now fails right in the middle
> > > > > of installation and needs the modprobe -r, modprobe stunt to network
> > > > > again.
> > > > 
> > > > Matt, Michael,
> > > > 
> > > > The tg3 driver has regressed for the 5714S since Linux 2.6.32.  Marc
> > > > Haber found this in the backported version included in our stable
> > > > update, but also confirmed it in Linux 3.0.
> > > > 
> > > > Bringing the interface down and then up again (which the installer does
> > > > for some reason) can leave it unable to pass traffic (possibly after
> > > > working for a few packets) until the module is reloaded.
> > > > 
> > > > I asked Marc to check whether reverting the power management changes
> > > > (071697e2bcd8dff2af4d6fdd6525c2324f89553b,
> > > > d237d9ecf06a00f0ebca657958cf2a1e92940796) made a difference, but it
> > > > doesn't seem to.
> > > > 
> > > > There is more information in the bug log at
> > > > <http://bugs.debian.org/645308>.
> > > 
> > > Where can I get the sources for this driver?  Commit
> > > 9e975cc291d80d5e4562d6bed15ec171e896d69b, entitled
> > > "tg3: Fix io failures after chip reset" has been a common source of
> > > problems.
> > 
> > Our current package has Linux 3.0.6 which includes the backport of that
> > change.  However, it is *not* included in my backport to 2.6.32 so it
> > doesn't explain the original report.
> > 
> > The backported version can be found in:
> > 
> > git://anonscm.debian.org/kernel/linux-2.6.git squeeze
> 
> The kernel version of that repository is 3.0.0-rc1.  Am I looking in the
> right place?

Look at the squeeze branch, not master.

Ben.

> But you're right.  The version of the driver in that repository does not
> have the change.
> 
> 

-- 
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Matt Carlson]

On Wed, Oct 26, 2011 at 12:41:44AM -0700, Ben Hutchings wrote:
> On Tue, 2011-10-25 at 17:20 -0700, Matt Carlson wrote:
> > On Mon, Oct 24, 2011 at 04:47:54PM -0700, Ben Hutchings wrote:
> > > On Mon, 2011-10-24 at 14:24 -0700, Matt Carlson wrote:
> > > > On Fri, Oct 21, 2011 at 05:19:39AM -0700, Ben Hutchings wrote:
> > > > > On Fri, 2011-10-21 at 11:08 +0200, Marc Haber wrote:
> > > > > > On Fri, Oct 21, 2011 at 11:00:46AM +0200, Marc Haber wrote:
> > > > > > > On Thu, Oct 20, 2011 at 05:28:34AM +0100, Ben Hutchings wrote:
> > > > > > > > I don't see any changes that would obviously change the way this device
> > > > > > > > is reconfigured during a down/up cycle.  There were some changes to
> > > > > > > > power management that should just let the PCI core do some work that the
> > > > > > > > driver used to, but it's possible that the result isn't quite the same.
> > > > > > > > I built a module with those reverted; source and binary attached.  Could
> > > > > > > > you test that?  I checked that d-i does include an insmod command.
> > > > > > > 
> > > > > > > The squeeze 6.0.3 installer with the shipped tg3.ko replaced with
> > > > > > > yours boots and networks just fine without any workaround and without
> > > > > > > manual interaction.
> > > > > > 
> > > > > > I was a bit fast on that. The interface now fails right in the middle
> > > > > > of installation and needs the modprobe -r, modprobe stunt to network
> > > > > > again.
> > > > > 
> > > > > Matt, Michael,
> > > > > 
> > > > > The tg3 driver has regressed for the 5714S since Linux 2.6.32.  Marc
> > > > > Haber found this in the backported version included in our stable
> > > > > update, but also confirmed it in Linux 3.0.
> > > > > 
> > > > > Bringing the interface down and then up again (which the installer does
> > > > > for some reason) can leave it unable to pass traffic (possibly after
> > > > > working for a few packets) until the module is reloaded.
> > > > > 
> > > > > I asked Marc to check whether reverting the power management changes
> > > > > (071697e2bcd8dff2af4d6fdd6525c2324f89553b,
> > > > > d237d9ecf06a00f0ebca657958cf2a1e92940796) made a difference, but it
> > > > > doesn't seem to.
> > > > > 
> > > > > There is more information in the bug log at
> > > > > <http://bugs.debian.org/645308>.
> > > > 
> > > > Where can I get the sources for this driver?  Commit
> > > > 9e975cc291d80d5e4562d6bed15ec171e896d69b, entitled
> > > > "tg3: Fix io failures after chip reset" has been a common source of
> > > > problems.
> > > 
> > > Our current package has Linux 3.0.6 which includes the backport of that
> > > change.  However, it is *not* included in my backport to 2.6.32 so it
> > > doesn't explain the original report.
> > > 
> > > The backported version can be found in:
> > > 
> > > git://anonscm.debian.org/kernel/linux-2.6.git squeeze
> > 
> > The kernel version of that repository is 3.0.0-rc1.  Am I looking in the
> > right place?
> 
> Look at the squeeze branch, not master.
> 
> Ben.
> 
> > But you're right.  The version of the driver in that repository does not
> > have the change.

O.K.  With Ben's help, I was able to see the diff between the two
driver versions.

I think I misspoke earlier.  The commit I mentioned above fixes a problem
introduced in an earlier patch.  (commit ID
d2394e6bb1aa636f3bd142cb6f7845a4332514b5, entitled
"tg3: Always turn on APE features in mac_mode reg")  So the fact that
2.6.32-35 works and 2.6.32-36 doesn't means you applied the problematic
patch that had the bug, but you didn't apply the above fix to correct it.

Sorry for the confusion.

Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Marc Haber]

On Fri, Nov 18, 2011 at 11:54:35AM -0800, Matt Carlson wrote:
> I think I misspoke earlier.  The commit I mentioned above fixes a problem
> introduced in an earlier patch.  (commit ID
> d2394e6bb1aa636f3bd142cb6f7845a4332514b5, entitled
> "tg3: Always turn on APE features in mac_mode reg")  So the fact that
> 2.6.32-35 works and 2.6.32-36 doesn't means you applied the problematic
> patch that had the bug, but you didn't apply the above fix to correct it.

I can try a fixed kernel, but I don't understand the way Debian builds
its kernels. I can

(a) download a Debian kernel source package, apply
d2394e6bb1aa636f3bd142cb6f7845a4332514b5 and go the make; make install
way or
(b) wait for a kernel deb from Ben.

If (a) is expected to give reasonable results, I can do that.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 31958061
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 31958062

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

On Sat, 2011-11-19 at 19:45 +0100, Marc Haber wrote:
> On Fri, Nov 18, 2011 at 11:54:35AM -0800, Matt Carlson wrote:
> > I think I misspoke earlier.  The commit I mentioned above fixes a problem
> > introduced in an earlier patch.  (commit ID
> > d2394e6bb1aa636f3bd142cb6f7845a4332514b5, entitled
> > "tg3: Always turn on APE features in mac_mode reg")  So the fact that
> > 2.6.32-35 works and 2.6.32-36 doesn't means you applied the problematic
> > patch that had the bug, but you didn't apply the above fix to correct it.
> 
> I can try a fixed kernel, but I don't understand the way Debian builds
> its kernels. I can
> 
> (a) download a Debian kernel source package, apply
> d2394e6bb1aa636f3bd142cb6f7845a4332514b5 and go the make; make install
> way or
> (b) wait for a kernel deb from Ben.
> 
> If (a) is expected to give reasonable results, I can do that.

I'm not going to build a complete new package myself, as you can easily
do that with the debian/bin/test-patches script in the source package.
But I can provide you with a rebuilt tg3.ko so you can test just that
change in the installer like you did previously.

Ben.

-- 
Ben Hutchings
The world is coming to an end.	Please log off.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Bug#645308: tg3 broken for NetXtreme 5714S in squeeze 6.0.3 installer

[Marc Haber]

On Sat, Nov 19, 2011 at 07:37:16PM +0000, Ben Hutchings wrote:
> But I can provide you with a rebuilt tg3.ko so you can test just that
> change in the installer like you did previously.

Already forgot about that. Yes, of course, that would be a way to go.
No need to hurry, I won't be on site before tuesday.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 31958061
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 31958062