From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: drivers/net/ethernet/apple
Date: Thu, 27 Oct 2011 00:45:35 -0700 [thread overview]
Message-ID: <1319701536.10258.74.camel@jtkirshe-mobl> (raw)
In-Reply-To: <CAMuHMdUW5PjPU7qNOPA16CbxHJs-bL4r+aFcEGV95SDRBotXRg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Wed, 2011-10-26 at 22:16 -0700, Geert Uytterhoeven wrote:
> Hi Jeff,
>
> On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal
> Semiconductor
> > (Now Cirrus Logic) CS89[02]0, so it belongs in
> drivers/net/ethernet/cirrus,
> > next to cs89x0.c.
>
> And on the first -next run since its inclusion:
>
> | drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
> such file or directory
>
> it needs the (shared) header file which is in
> drivers/net/ethernet/cirrus/.
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/
Ah, yeah, now it is coming back to me why I placed cs89x0.[ch] in the
drivers/net/ethernet/apple/ because it was grouped with the "common"
drivers. The intent was to group drivers that use common code together.
I can put together a patch to fix this if you are not able to.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-10-27 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 20:19 drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 5:16 ` drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 7:45 ` Jeff Kirsher [this message]
2011-10-27 8:40 ` drivers/net/ethernet/apple Geert Uytterhoeven
2011-10-27 7:46 ` drivers/net/ethernet/apple Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319701536.10258.74.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).