From: Michael Riesch <michael@riesch.at>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Oliver Neukum <oneukum@suse.de>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
devel@openvz.org
Subject: Re: [PATCH] usbnet: fix oops in usbnet_start_xmit
Date: Mon, 07 Nov 2011 14:29:13 +0100 [thread overview]
Message-ID: <1320672553.2909.41.camel@malcolm> (raw)
In-Reply-To: <20111106183337.5379.4356.stgit@zurg>
On Sun, 2011-11-06 at 22:33 +0300, Konstantin Khlebnikov wrote:
> This patch fixes the bug added in commit v3.1-rc7-1055-gf9b491e
> SKB can be NULL at this point, at least for cdc-ncm.
OK, I didn't think of that, but...
> Let's call skb_tx_timestamp() after driver specific tx-fixup hacks.
... the reason I put the skb_tx_timestamp() call before the tx_fixup is
that these hacks often perform skb_push/skb_pull or any other kind of
framing. This may result (at least in the case of the asix drivers) in
perfectly correct PTP packets being not recognized as such by the packet
filter.
Can we do a check like this:
if(skb) skb_tx_timestamp()
tx_fixup()
?
Regards, Michael
next prev parent reply other threads:[~2011-11-07 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 19:33 [PATCH] usbnet: fix oops in usbnet_start_xmit Konstantin Khlebnikov
2011-11-07 13:29 ` Michael Riesch [this message]
2011-11-07 13:33 ` Richard Cochran
2011-11-07 14:05 ` Konstantin Khlebnikov
2011-11-07 14:42 ` Richard Cochran
2011-11-07 15:54 ` [PATCH v2] " Konstantin Khlebnikov
2011-11-07 17:39 ` Richard Cochran
2011-11-07 18:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320672553.2909.41.camel@malcolm \
--to=michael@riesch.at \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=khlebnikov@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).